Re: [PATCH][RFC] allow local file:// URLs for svnadmin
Daniel Shahaf <[email protected]> Fri, 4 Dec 2009 20:23:36 +0200 (Jerusalem Standard Time)
| Newsgroups | gmane.comp.version-control.subversion.devel,gmane.comp.version-control.subversion.rapidsvn.devel |
|---|---|
| Message-ID | <[email protected]> |
Julian Foad wrote on Fri, 4 Dec 2009 at 18:16 -0000: > Daniel Shahaf wrote: > > Philip Martin wrote on Fri, 4 Dec 2009 at 15:51 -0000: > > > Julian Foad <[email protected]> writes: > > > > > > > Vincent Legoll wrote: > > > >> I think there's nothing preventing svnadmin to accept local > > > >> file:// URLs as repository location parameter. So why not ? > > > > > > I think it's a bad idea because svnadmin doesn't use the RA layer. > > > > That's my initial reaction as well. Nowhere do we accept file:/// URLs > > instead of paths: not in the API, not in svn (you can't say > > "svn info file://path/to/wc"), etc. > > Spurious analogy. We're not talking about accepting URLs to WCs, only to > repositories. I was in an "accept a file:// URL as an alias for the path it points to" mood. > The converse comparison is: nowhere do we not accept a URL > to refer to a repository, except currently in svnadmin/svnlook. (Sure, > there's the "not a general RA access" argument, etc. to consider, and > I'm not fighting for accepting it, just responding to your statement.) > In general, 'svn' mirrors the client API and 'svnadmin' mirrors the repos API. If we want svnadmin to accept file:// URLs, shouldn't svn_repos_open() accept them too? (I'm not saying it shouldn't; I'm saying that, if svnadmin is extended, we may extend the repos API in the same manner.) > - Julian > > ------------------------------------------------------ > http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2427139 > > Please start new threads on the <[email protected]> mailing list. > To subscribe to the new list, send an empty e-mail to <[email protected]>. > ------------------------------------------------------ http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2427144 Please start new threads on the <[email protected]> mailing list. To subscribe to the new list, send an empty e-mail to <[email protected]>.