Re: Property columns

Before adding this patch to the codebase some remarks:
the prop.entries call will be placed for every single file in a list.
If you have recursive on, or even worse are browsing a repository this 
will have the effect of slowing down (many files) to being unusable 
(repository browsing).

Some options:
- either as columns that can be switch on/off (but the user might not
   know about the consequences)
- switching off the column if flat mode is on or a repository is being
   browsed (would be my favourite)

What do you think?

Alex



Am 06.04.2010 08:30, schrieb Greg Toombs:
> I wrote a small patch that allows for some quite useful columns to be added to RapidSVN. If you could integrate this that would be great!
>
> filelist_ctrl.cpp:
>
> 41d40
> <  #include "svncpp/property.hpp"
> 1245,1256d1243
> <  	
> <  	const svn::Property prop(GetContext(), fullPath);
> <  	const std::vector<svn::PropertyEntry>  &entries = prop.entries();
> <  	for (std::vector<svn::PropertyEntry>::const_iterator it = entries.begin();
> <  		it != entries.end(); it++) {
> <  		if (it->name == "svn:mime-type")
> <  			values[COL_PROP_MIMETYPE] = Utf8ToLocal(it->value);
> <  		else if (it->name == "svn:keywords")
> <  			values[COL_PROP_KEYWORDS] = Utf8ToLocal(it->value);
> <  		else if (it->name == "svn:eol-style")
> <  			values[COL_PROP_EOL]      = Utf8ToLocal(it->value);
> <  	}
> 1326c1313
> <  	
> ---
>>
>
>
> filelist_ctrl.hpp:
>
> 86,88d85
> <  	COL_PROP_MIMETYPE,
> <  	COL_PROP_KEYWORDS,
> <  	COL_PROP_EOL,
>
>
> columns.cpp:
>
> 67,69d66
> <    COLUMNS[22] = Column(wxT("PropMimetype"), _("svn:mime-type"), ID_Column_PropMimeType);
> <    COLUMNS[23] = Column(wxT("PropKeywords"), _("svn:keywords"),  ID_Column_PropKeywords);
> <    COLUMNS[24] = Column(wxT("PropEOL"),      _("svn:eol-style"), ID_Column_PropEOL);
>
>
> ids.hpp:
>
> 138,140d137
> <    ID_Column_PropMimeType,
> <    ID_Column_PropKeywords,
> <    ID_Column_PropEOL,
>
>
> Cheers.
>
> ------------------------------------------------------
> http://rapidsvn.tigris.org/ds/viewMessage.do?dsForumId=668&dsMessageId=2495565
>
> To unsubscribe from this discussion, e-mail: [[email protected]].

------------------------------------------------------
http://rapidsvn.tigris.org/ds/viewMessage.do?dsForumId=668&dsMessageId=2496663

To unsubscribe from this discussion, e-mail: [[email protected]].