RE: Re: subclipse 1.8.9 - compare with branch/tag problem

Hi Mark,
Thank you for your response. 
Indeed the problem is that lastChangedRevision is used as a base revision for comparison whereas HEAD would be more appropriate in that case. 
Making additional commit in trunk helps temporarily however I believe that proper fix should be provided anyway. 

Shall I create Subclipse Issue to tack this bug?
 
regards,
Piotr Wilkosz

> This is the commit that causes the problem:
> 
> http://subclipse.tigris.org/source/browse/subclipse?view=rev&revision=5268
> 
> As soon as you make another change to trunk this problem will
> disappear.  It looks like it uses the lastChangedRevision of the
> selected resource to set the pegRevision when checking for the URL
> that you are comparing with.  I think it should just use the revision
> specified in the dialog, but there might be scenarios where this
> change was trying to fix something, for example when comparing to
> another revision of the same URL.
> 
> I will leave it for Steve to fix this.  I am guessing he probably
> needs to set the pegRevision to the revision entered in the dialog
> unless the URL in the dialog matches the URL of the selected item.
> 
> Mark
> 
> 
> 
> On Wed, May 30, 2012 at 11:11 AM, Piotr Wilkosz <Piotr dot Wilkosz at gmail dot com> wrote:
> > Hi,
> > Eclipse "compare with branch/tag" functionality doesn't seem work correctly
> > for newly created tags.
> > Please confirm if this is a bug or correct me if I'm doing something wrong here:
> >
> > 1. create project trunk and check it out:
> > svn mkdir http://subversion.assembla.com/svn/subclipse/trunk
> > svn co http://subversion.assembla.com/svn/subclipse/trunk ~/subclipse-bug
> > cd ~/subclipse-bug
> >
> > 2. add some example file:
> > echo "content" > file.txt
> > svn add file.txt
> > svn ci -m 'adding new file' file.txt
> >
> > 3. make a tag out of the trunk:
> > svn mkdir http://subversion.assembla.com/svn/subclipse/tags
> > svn cp http://subversion.assembla.com/svn/subclipse/trunk
> > http://subversion.assembla.com/svn/subclipse/tags/0.0.1 -m'create new
> > tag'
> >
> > 4. go to Eclipse and import new project from SVN
> > http://subversion.assembla.com/svn/subclipse/trunk
> > So far so good ;-)
> >
> > 5. Right click on newly imported project choose "Compare With... ->
> > Branch/Tag" from context menu.
> >
> > Now "Compare with Branch/Tag" dialog windows pops up.
> >
> > 6. In "Compare to:" dialog type in
> > http://subversion.assembla.com/svn/subclipse/tags/0.0.1 and click "OK"
> >
> > Comparison fail with following error message on console:
> > svn: E160013: '/svn/subclipse/!svn/bc/2/tags/0.0.1' path not found:
> > 404 Not Found (http://subversion.assembla.com)
> >
> > Additionally I following error message in new dialog window.
> > org.apache.subversion.javahl.ClientException: svn: E160013:
> > '/svn/subclipse/!svn/bc/2/tags/0.0.1' path not found: 404 Not Found
> > (http://subversion.assembla.com)
> >
> > Of course http://subversion.assembla.com/svn/subclipse/tags/0.0.1 url
> > is valid and can be found in HEAD revision
> > What seems to be strange for me is that subclipse is trying to get the
> > tag in revision #2 (LastChangedRevision of trunk) whereas the tag
> > itself been committed as revision #3
> >
> > Any idea if what may be wrong here?
> >
> > My configuration is:
> > Apache Subversion version 1.7.1 (r1186859).
> > Eclipse SDK Indigo version 3.7.2 Build id: M20120208-0800
> > org.tigris.subversion.clientadapter.feature 1.8.2
> > org.tigris.subversion.clientadapter.javahl.feature 1.7.4.1
> > org.tigris.subversion.subclipse.graph.feature 1.1.1
> > org.tigris.subversion.subclipse 1.8.9
> > org.tigris.subversion.clientadapter.svnkit.feature 1.7.4
> >
> >
> > Please let me know if you can reproduce this problem and if I supposed
> > to file bug report for that issue.
> >
> >
> > best regards
> > Piotr Wilkosz
> > Disclaimer: Any errors in spelling, tact, or fact are transmission errors.
> >
> > ------------------------------------------------------
> > http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=2967594
> >
> > To unsubscribe from this discussion, e-mail: [users-unsubscribe at subclipse dot tigris dot org].
> 
> 
> 
> -- 
> Thanks
> 
> Mark Phippard
> http://markphip.blogspot.com/

------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=2968644

To unsubscribe from this discussion, e-mail: [[email protected]].