autoconf out-of-tree builds broken (was: svn commit: r1920955 - in /subversion/trunk: configure.ac subversion/tests/cmdline/ subversion/tests/cmdline/svneditor.sh subversion/tests/cmdline/svneditor.sh.in)

[email protected] wrote on Thu, 26 Sep 2024 13:22 +00:00:
> Fix command-line tests on Linux by removing configuration of svneditor.sh
> script.
>
> See also 'Removing configuration of svneditor.sh script?' thread on dev@ [1].

The log message says "Fix", but neither the log message nor the thread
explains what wasn't working.

More importantly, using trunk@HEAD:

[[[
% cd "$(mktemp -d)"
% /path/to/trunk/wc/configure
% make && make check
⋮
W: sh: 1: /tmp/tmp.7S856JAlU6/svn/subversion/tests/cmdline/svneditor.sh: not found
W: svn: E200012: system('/tmp/tmp.7S856JAlU6/svn/subversion/tests/cmdline/svneditor.sh "svn-prop.tmp"') returned 32512
W: CWD: /tmp/tmp.7S856JAlU6/svn/subversion/tests/cmdline
W: EXCEPTION: Failure: Command failed: "/tmp/tmp.7S856JAlU6/svn/subversion/svn/svn propedit -m msg ..."; exit code 1
Traceback (most recent call last):
⋮
  File "/path/to/trunk/wc/subversion/tests/cmdline/svntest/main.py", line 694, in run_command_stdin
    raise Failure('Command failed: "' + brief_command +
svntest.Failure: Command failed: "/tmp/tmp.7S856JAlU6/svn/subversion/svn/svn propedit -m msg ..."; exit code 1
FAIL:  commit_tests.py 48: set revision props during remote property edit
]]]

Reverting r1920955 makes that test PASS.

Please fix.

Daniel

P.S.  Don't we have a single CI job doing out-of-tree builds?


> * configure.ac
>   (configscripts): Do not configure 'svneditor.sh' script.
> * subversion/tests/cmdline
>   (svn:ignore): Remove 'svneditor.sh' from ignores.
> * subversion/tests/cmdline/svneditor.sh: Rename from svneditor.sh.in and...
>   (python path): Retrieve it from SVN_TEST_PYTHON environment variable instead
>    of configuring it.
>   (source dir): Using `$(dirname $0)` shell magic for determining source dir,
>    instead of configuring it.
> * subversion/tests/cmdline/svneditor.sh.in: Renamed to svneditor.sh.
>
> [1] https://lists.apache.org/thread/b64t53r5055tv2s2b37r4wpk4qtw00y8