svn commit: r1926388 - /subversion/trunk/build/generator/gen_cmake.py

Author: rinrab
Date: Fri Jun 13 12:55:11 2025
New Revision: 1926388

URL: http://svn.apache.org/viewvc?rev=1926388&view=rev
Log:
In relation to r1926386, hardcode PUBLIC_LIB_DEPENDS to improve readability.

- We don't care of performance in this script at all. This is just a code
  generator for our build-system. Let's keep things simple.

* build/generator/gen_cmake.py
  (PUBLIC_LIB_DEPENDS): Removed from here.
  (Generator.write): List all dep_names explicitly and move comments from
   PUBLIC_LIB_DEPENDS.

No functional changes.

Modified:
    subversion/trunk/build/generator/gen_cmake.py

Modified: subversion/trunk/build/generator/gen_cmake.py
URL: http://svn.apache.org/viewvc/subversion/trunk/build/generator/gen_cmake.py?rev=1926388&r1=1926387&r2=1926388&view=diff
==============================================================================
--- subversion/trunk/build/generator/gen_cmake.py (original)
+++ subversion/trunk/build/generator/gen_cmake.py Fri Jun 13 12:55:11 2025
@@ -53,10 +53,6 @@ def get_module_name(name):
 
   return name[7:].upper()
 
-# APR and APR-Util are part of our public interface and should be
-# declared PUBLIC in library target dependencies.
-PUBLIC_LIB_DEPENDS = frozenset(["external-apr", "external-aprutil"])
-
 def get_output_name(target):
   if target.name.startswith("lib"):
     return target.name[3:] + "-1"
@@ -176,7 +172,10 @@ class Generator(gen_base.GeneratorBase):
               pass
             else:
               dep_name = "external-" + dep.name
-              if (dep_name in PUBLIC_LIB_DEPENDS
+
+              # APR and APR-Util are part of our public interface and should be
+              # declared PUBLIC in library target dependencies.
+              if (dep_name in ["external-apr", "external-aprutil"]
                   and not isinstance(target, gen_base.TargetExe)):
                 public_libs.append(dep_name)
               else: