svn commit: r1930404 - subversion/branches/utf8-cmdline-prototype/subversion/svnadmin

[email protected]
Newsgroups gmane.comp.version-control.subversion.svn
Message-ID <176530899680.2870040.13472137719649709239@svn02-us-east.apache.org>
Author: rinrab
Date: Tue Dec  9 19:36:35 2025
New Revision: 1930404

Log:
On the 'utf8-cmdline-prototype' branch: svnadmin: Duplicate strings in a pool
when processing command-line arguments.

* subversion/svnadmin/svnadmin.c
  (sub_main): Some apr_pstrdup-ing.

Modified:
   subversion/branches/utf8-cmdline-prototype/subversion/svnadmin/svnadmin.c

Modified: subversion/branches/utf8-cmdline-prototype/subversion/svnadmin/svnadmin.c
==============================================================================
--- subversion/branches/utf8-cmdline-prototype/subversion/svnadmin/svnadmin.c	Tue Dec  9 19:24:13 2025	(r1930403)
+++ subversion/branches/utf8-cmdline-prototype/subversion/svnadmin/svnadmin.c	Tue Dec  9 19:36:35 2025	(r1930404)
@@ -3133,7 +3133,7 @@ sub_main(int *exit_code,
         }
         break;
       case 't':
-        opt_state.txn_id = utf8_opt_arg;
+        opt_state.txn_id = apr_pstrdup(pool, utf8_opt_arg);
         break;
 
       case 'q':
@@ -3152,7 +3152,7 @@ sub_main(int *exit_code,
         }
         break;
       case 'F':
-        opt_state.file = utf8_opt_arg;
+        opt_state.file = apr_pstrdup(pool, utf8_opt_arg);
         dash_F_arg = TRUE;
         break;
       case svnadmin__version:
@@ -3231,7 +3231,7 @@ sub_main(int *exit_code,
         opt_state.metadata_only = TRUE;
         break;
       case svnadmin__fs_type:
-        opt_state.fs_type = utf8_opt_arg;
+        opt_state.fs_type = apr_pstrdup(pool, utf8_opt_arg);
         break;
       case svnadmin__parent_dir:
         opt_state.parent_dir = svn_dirent_internal_style(utf8_opt_arg, pool);
@@ -3282,12 +3282,14 @@ sub_main(int *exit_code,
       case svnadmin__exclude:
         if (! opt_state.exclude)
           opt_state.exclude = apr_array_make(pool, 1, sizeof(const char *));
-        APR_ARRAY_PUSH(opt_state.exclude, const char *) = utf8_opt_arg;
+        APR_ARRAY_PUSH(opt_state.exclude, const char *)
+          = apr_pstrdup(pool, utf8_opt_arg);
         break;
       case svnadmin__include:
         if (! opt_state.include)
           opt_state.include = apr_array_make(pool, 1, sizeof(const char *));
-        APR_ARRAY_PUSH(opt_state.include, const char *) = utf8_opt_arg;
+        APR_ARRAY_PUSH(opt_state.include, const char *)
+          = apr_pstrdup(pool, utf8_opt_arg);
         break;
       case svnadmin__glob:
         opt_state.glob = TRUE;
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.