svn commit: r1931359 - subversion/trunk/subversion/libsvn_subr

[email protected]
Newsgroups gmane.comp.version-control.subversion.svn
Message-ID <176857148179.2745476.12377334833802702041@svn02-us-east.apache.org>
Author: brane
Date: Fri Jan 16 13:51:21 2026
New Revision: 1931359

Log:
Follow up to r1931334: Correct and clarify comments. No functional change.

* subversion/libsvn_subr/adler32.c
  (svn__adler32): Fix the comment about compile-time code elision.
   Add another to explain why we use a not strictly necessary variable.

Modified:
   subversion/trunk/subversion/libsvn_subr/adler32.c

Modified: subversion/trunk/subversion/libsvn_subr/adler32.c
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/adler32.c	Fri Jan 16 12:35:44 2026	(r1931358)
+++ subversion/trunk/subversion/libsvn_subr/adler32.c	Fri Jan 16 13:51:21 2026	(r1931359)
@@ -67,12 +67,12 @@ svn__adler32(apr_uint32_t checksum, cons
 {
   /* Process large amounts of data in max-sized chunks.
    *
-   * Note: > not >=, then if sizeof(apr_off_t) <= SVN__ADLER32_SIZE_MAX
-   *                 this whole block can be deleted at compile time ...
+   * Note: > not >=; then if sizeof(apr_off_t) <= sizeof(svn__adler32_size_t),
+   *                 this whole code block can be elided at compile time ...
    */
   if (SVN__PREDICT_FALSE(len > SVN__ADLER32_SIZE_MAX))
     {
-      uLong partial = checksum;
+      uLong partial = checksum; /* Avoid typecasts in the while loop. */
       /* ... but >= here because we just might get lucky and
        *     consume all the data in this loop.
        */
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.