Re: svn commit: r1808139 - in /subversion/branches/better-pristines/subversion: include/svn_client.h libsvn_client/checkout.c libsvn_client/deprecated.c svn/checkout-cmd.c tests/libsvn_wc/utils.c

I stumbled upon something while reviewing the docstring fixes and I don't quite understand. I had to do some acheology to find the original commit, this has subsequently been merged through several branches and the code now exist in trunk.

On 2017/09/12 17:50:05 [email protected] wrote:
> Author: brane
> Date: Tue Sep 12 17:50:05 2017
> New Revision: 1808139
> 
> URL: http://svn.apache.org/viewvc?rev=1808139&view=rev
> Log:
> On the better-pristines branch: Add WC format parameter to svn_client_checkout.
...
> ==============================================================================
> --- subversion/branches/better-pristines/subversion/libsvn_client/deprecated.c (original)
> +++ subversion/branches/better-pristines/subversion/libsvn_client/deprecated.c Tue Sep 12 17:50:05 2017
> @@ -2531,6 +2531,24 @@ svn_client_cat(svn_stream_t *out,
>  
>  /*** From checkout.c ***/
>  svn_error_t *
> +svn_client_checkout3(svn_revnum_t *result_rev,
> +                     const char *URL,
> +                     const char *path,
> +                     const svn_opt_revision_t *peg_revision,
> +                     const svn_opt_revision_t *revision,
> +                     svn_depth_t depth,
> +                     svn_boolean_t ignore_externals,
> +                     svn_boolean_t allow_unver_obstructions,
> +                     svn_client_ctx_t *ctx,
> +                     apr_pool_t *pool)
> +{
> +  return svn_error_trace(svn_client_checkout4(
> +                             result_rev, URL, path,
> +                             peg_revision, revision, depth,
> +                             ignore_externals, FALSE, NULL, ctx, pool));

Is there a reason why allow_unver_obstructions is not used here (it should be in place of FALSE) or is this just an oversight?

> +}
> +
> +svn_error_t *
>  svn_client_checkout2(svn_revnum_t *result_rev,
>                       const char *URL,
>                       const char *path,

Thanks,
Daniel