svn commit: r1935782 - subversion/trunk/subversion/tests/libsvn_subr
[email protected] Wed, 01 Jul 2026 18:18:30 -0000
| Newsgroups | gmane.comp.version-control.subversion.svn |
|---|---|
| Message-ID | <178292991054.3425733.15548601625818483965@svn03-he-fi> |
Author: ivan
Date: Wed Jul 1 18:18:30 2026
New Revision: 1935782
Log:
Simplify test code.
* subversion/tests/libsvn_subr/skel-test.c
(put_explicit_length): Use BUF only for length and separator. This avoids
malloc()/free() and memcpy().
Modified:
subversion/trunk/subversion/tests/libsvn_subr/skel-test.c
Modified: subversion/trunk/subversion/tests/libsvn_subr/skel-test.c
==============================================================================
--- subversion/trunk/subversion/tests/libsvn_subr/skel-test.c Wed Jul 1 18:08:13 2026 (r1935781)
+++ subversion/trunk/subversion/tests/libsvn_subr/skel-test.c Wed Jul 1 18:18:30 2026 (r1935782)
@@ -308,9 +308,7 @@ put_explicit_length(svn_stringbuf_t *str
apr_size_t len,
char sep)
{
- const apr_size_t alloc_len = len + 100;
- char *buf = malloc(alloc_len);
- apr_size_t length_len;
+ char buf[100];
if (! skel_is_space(sep))
abort();
@@ -321,13 +319,11 @@ put_explicit_length(svn_stringbuf_t *str
#else
sprintf(buf, "%" APR_SIZE_T_FMT "%c", len, sep);
#endif
- length_len = strlen(buf);
- /* Copy in the real data (which may contain nulls). */
- memcpy(buf + length_len, data, len);
+ svn_stringbuf_appendcstr(str, buf);
- svn_stringbuf_appendbytes(str, buf, length_len + len);
- free(buf);
+ /* Copy in the real data (which may contain nulls). */
+ svn_stringbuf_appendbytes(str, data, len);
}