Re: svn commit: r1936631 - in subversion/trunk: . subversion/tests/libsvn_fs_fs

Daniel Sahlberg <[email protected]> Tue, 28 Jul 2026 09:29:03 +0200
Newsgroups gmane.comp.version-control.subversion.svn,gmane.comp.java.ofbiz.devel
Message-ID <CAMHy98Ohr2Kmme5wykfhKV7wY4pk3pOZW=sTcqFQRe485G+knA__31995.222046838$1785223799$gmane$org@mail.gmail.com>
--000000000000e20b3a0657a6cb07
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Den m=C3=A5n 27 juli 2026 kl 12:48 skrev <[email protected]>:

> Author: ivan
> Date: Mon Jul 27 10:48:05 2026
> New Revision: 1936631
>

...

> +    /* Create 10 revisions. */
> +    for (i =3D 1; i < 10; ++i)
> +      {
> +        svn_fs_txn_t *txn;
> +        svn_fs_root_t *txn_root;
> +        svn_revnum_t new_rev =3D 0;
> +
> +        svn_pool_clear(iterpool);
> +
> +        SVN_ERR(svn_fs_begin_txn(&txn, fs, new_rev, iterpool));
> +        SVN_ERR(svn_fs_txn_root(&txn_root, txn, iterpool));
> +        SVN_ERR(svn_fs_make_dir(txn_root, apr_itoa(pool, i), iterpool));
>

Is it intentional to use pool instead of iterpool in the call to apr_itoa?

Cheers,
Daniel

--000000000000e20b3a0657a6cb07
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><span style=3D"background-color:transpare=
nt">Den m=C3=A5n 27 juli 2026 kl 12:48 skrev &lt;<a href=3D"mailto:ivan@apa=
che.org">[email protected]</a>&gt;:</span></div><div class=3D"gmail_quote gma=
il_quote_container"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0=
px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Autho=
r: ivan<br>
Date: Mon Jul 27 10:48:05 2026<br>
New Revision: 1936631<br></blockquote><div><br></div><div>...</div><blockqu=
ote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px=
 solid rgb(204,204,204);padding-left:1ex">
+=C2=A0 =C2=A0 /* Create 10 revisions. */<br>
+=C2=A0 =C2=A0 for (i =3D 1; i &lt; 10; ++i)<br>
+=C2=A0 =C2=A0 =C2=A0 {<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 svn_fs_txn_t *txn;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 svn_fs_root_t *txn_root;<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 svn_revnum_t new_rev =3D 0;<br>
+<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 svn_pool_clear(iterpool);<br>
+<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 SVN_ERR(svn_fs_begin_txn(&amp;txn, fs, new_rev=
, iterpool));<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 SVN_ERR(svn_fs_txn_root(&amp;txn_root, txn, it=
erpool));<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 SVN_ERR(svn_fs_make_dir(txn_root, apr_itoa(poo=
l, i), iterpool));<br></blockquote><div><br></div><div>Is it intentional to=
 use pool instead of iterpool in the call to apr_itoa?</div><div>=C2=A0</di=
v><div><span style=3D"background-color:transparent">Cheers,</span></div><di=
v><span style=3D"background-color:transparent">Daniel</span></div><div><br>=
</div></div></div>

--000000000000e20b3a0657a6cb07--