RE: CCommitDlg::OnOK - cancelling the TaskDialog after CheckCommit leads into an unwanted commit
Jens Wilhelm <[email protected]>
| Newsgroups | gmane.comp.version-control.subversion.tortoisesvn.devel |
|---|---|
| Message-ID | <792156283.2977.1473348662629.JavaMail.httpd@localhost> |
In other words: /trunk/src/TortoiseProc/CommitDlg.cpp Rev. 27110 Line 537 I would replace: bool doIt = (taskdlg.DoModal(GetSafeHwnd()) == 1); by: bool doIt = (taskdlg.DoModal(GetSafeHwnd()) != 2); because doIt stands for abort. Commit should only proceed if the user inputs "proceed ...". Cancelling taskdlg shoud not lead into commit. Best regards ------------------------------------------------------ http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3185168 To unsubscribe from this discussion, e-mail: [[email protected]].