Re: "Display 'moved here' and 'moved away' status in working copy status list

On 28.09.2016 17:44, Stefan Hett wrote:
> On 9/28/2016 4:52 PM, Ivan Zhakov wrote:
>> On 28 September 2016 at 12:49, Stefan Hett <[email protected]> wrote:
>>> On 9/28/2016 11:34 AM, Ivan Zhakov wrote:
>>>> Hi,
>>>>
>>>> Subversion records moves as first-class operation in the working copy
>>>> since version 1.8 [1]. For example here is how 'svn status' looks for
>>>> working copy where file 'foo.txt' was renamed to 'bar.txt':
>>>> [[[
>>>> A  +    bar.txt
>>>>           > moved from foo.txt
>>>> D       foo.txt
>>>>           > moved to bar.txt
>>>> ]]]
>>>>
>>>> But TortoiseSVN only displays this information in a tooltip in the
>>>> status list. I suggest adding 'moved here' and 'moved away' to
>>>> TortoiseSVN. See the attached patch and screenshot.
>>>>
>>>> [1] https://subversion.apache.org/docs/release-notes/1.8.html#moves
>>>>
>>>>
>>> Feedback from a user's point of view (if that's helpful):
>>> How about only displaying a single entry for both operations as in:
>>>
>>> Path        Extension    Status
>>>
>>> bar.txt     txt          moved from foo.txt
>>>
>>>
>>> IMO that would make more sense to the user and simplifies the
>>> use-case/UI a bit.
>>> It will also solve the problem with the current approach that if you
>>> have two renames/moves, you don't really see which entries are related
>>> to one another.
>>>
>>> I certainly can't say whether combining the two entries to a single one
>>> will break current use-cases and/or require much work to adjust these,
>>> so it might be out of question and you already considered (and therefore
>>> rejected) that idea.
> Thanks for taking the time to review my points, Ivan.
>
>> 1. This will require to user to configure Status column to be very
>> wide. Just imagine something like:
>>
>> Path
>> subversion\bindings\javahl\src\org\apache\subversion\javahl\ClientException.java
>>   moved from subversion\bindings\javahl\src\org\tigris\subversion\javahl\Exception.java
> Possible solution: Use a relative path to display there (moved from
> ...\tigris\subversion\javahl\Exception.java) and add a mouse-over
> tooltip to display the full path.
> Also I the common case of a simple rename (rather than a move(+rename))
> would still benefit from that style without that problem (since there
> only the old filename would be displayed).
> Certainly for the general case it can end up with a rather long path
> (but then I take it it's ok that for these cases the column width would
> have to be manually extended to see the full name (or use mouse over
> tooltips to show the full path while in the column the path would be
> displayed truncated as in "moved from subversion\bind...").

I like the idea.
As for long paths: we could use PathCompactEx or PathCompactPath to 
limit the path lengths when showing, but still show the full info in the 
tooltip.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3187534

To unsubscribe from this discussion, e-mail: [[email protected]].