Re: Restore selection list after applying filter
Dani Soufi <[email protected]>
| Newsgroups | gmane.comp.version-control.subversion.tortoisesvn.devel |
|---|---|
| Message-ID | <[email protected]> |
Correct you have something in place but it works only for the current visible list. The previously visible list is also forgotten. So this patch tracks the previous selection and then applies it back on every changed list. Regards Dani > Am 01.10.2016 um 10:46 schrieb Stefan Küng <[email protected]>: > >> On 30.09.2016 12:51, Dani Soufi wrote: >> Dear devs, >> >> I encoutered recently an annoyance while working on a large project. I >> selected several commits to merge into a seperate branch, no problem >> there. Then I applied a filter to select some other commits, no problems >> there too. Now when I clear the filter, only the recently selected list >> is restored but my previous selection is deselected. Actually, the >> selection list is restored only for the current visible list and does >> not work for all the previous selects if the list was reloaded/filtered. >> This is a huge annoyance when you use alot of filtering, some selects >> will be lost and you need to keep track of them. >> >> That's why I submit a patch to fix this. >> >> The patch was developed and tested against r27333. > > Thanks for the patch. > But I think this is the wrong way to approach the issue: > we already have something in place to restore selections/checkmarks. > Your patch introduces a second way to do that, and leaves the existing > one in place which leads to sometimes multiple restores. > > I'll try to improve the restore some other way... > > Stefan > > -- > ___ > oo // \\ "De Chelonian Mobile" > (_,\/ \_/ \ TortoiseSVN > \ \_/_\_/> The coolest interface to (Sub)version control > /_/ \_\ http://tortoisesvn.net > > ------------------------------------------------------ > http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3187878 > > To unsubscribe from this discussion, e-mail: [[email protected]]. ------------------------------------------------------ http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3187898 To unsubscribe from this discussion, e-mail: [[email protected]].