Re: Trunk build: redefinition errors on CrashHandler SendRpt

On 9/4/2017 1:54 PM, Julian Foad wrote:
> Hello. I'm trying to compile TSVN for the first time ever, being
> unfamiliar with compiling on Windows (last did it about 15 years ago),
> and running into some trivial problem to which I don't know the
> answer.
>
> Compiling fails for me on the CrashHandler, with many errors all of
> the following form:
>
> [exec] C:\Program Files (x86)\Windows
> Kits\8.1\Include\shared\ws2def.h(221): error C2011: 'sockaddr':
> 'struct' type redefinition
> [C:\jenkins\workspace\TSVN_trunk\TortoiseSVN\ext\crashserver\CrashHandler\SendRpt\SendRpt.vcxproj]
> [exec]   C:\Program Files (x86)\Windows
> Kits\8.1\Include\um\winsock.h(1002): note: see declaration of
> 'sockaddr'
>
> (This machine has both VS2015 and VS2017 installed, as I was also
> trying to build TSVN 1.9.)
>
> Any ideas what's wrong, or what information I can provide to help
> debug this, please?
>
> And is there an instant messaging channel we can use for quicker
> communication on this?
>
> Thanks,
> - Julian
>
> ------------------------------------------------------
> http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3297661
>
> To unsubscribe from this discussion, e-mail: [[email protected]].
>
Just tried it with a fresh VS2017 installation. Same issue here. My 
workaround for the problem is to simply add the following include to 
\ext\CrashServer\CrashHandler\SendRpt\stdafx.h:

#include <WinSock2.h>

(right above the asser.h-include).

I didn't dig into the details what's exactly wrong there, but this does 
the trick to me.

-- 
Regards,
Stefan Hett

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3297816

To unsubscribe from this discussion, e-mail: [[email protected]].