Re: [PATCH] Empty message box when applying a patch that does not affect any files

Sorry I missed the empty.patch.txt.

On Thursday, February 10, 2022 at 1:57:47 AM UTC+3 Denis Kovalchuk wrote:

> Hello!
>
> Steps to reproduce:
> 1. Download the empty.patch from attachments.
> 2. Open TortoiseMerge.exe.
> 3. Enter the path to the empty.patch.
> 4. Enter the path to any working copy.
> 5. Click "OK".
>
> The same behavior if you try to apply any file that is not a patch. It 
> looks
> like if the applied file does not affect any files, then it is considered 
> an
> error (see line 782 in TortoiseMerge/MainFrm.cpp [1]). But 
> SVNPatch::Init() [2]
> does not set an error message in this case.
>
> What do you think if this case is not treated as an error? I've attached a
> patch.
>
> [1] 
> https://osdn.net/projects/tortoisesvn/scm/svn/blobs/head/trunk/src/TortoiseMerge/MainFrm.cpp
> [2] 
> https://osdn.net/projects/tortoisesvn/scm/svn/blobs/head/trunk/src/SVN/SVNPatch.cpp
>
> Best Regards,
> Denis Kovalchuk
>

-- 
You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn-dev/e703ff3e-1122-4934-b4ee-30b03c4b83den%40googlegroups.com.