Re: All TortoiseSVN 1.10+ builds inadvertently compile with APR_HAVE_IPV6 = 1?

The ipv6 build option was removed in r29394.

Would it also make sense to remove the ipv6 scripts in contrib\choco? I've 
searched the source and I can't find them being used anywhere anymore.
tisdag 17 maj 2022 kl. 20:09:36 UTC+2 skrev Evgeny Kotkov:

> Hi,
>
> I see that all TortoiseSVN 1.10 and later builds (both regular and "-ipv6")
> have been compiled with APR_HAVE_IPV6 = 1.
>
> This happened because APR 1.6 changed the default value for APR_HAVE_IPV6
> from 0 to 1, so apr.build tries to replace the string that no longer 
> exists:
>
>     <replacestring from="#define APR_HAVE_IPV6           0"
>                    to="#define APR_HAVE_IPV6           1"
>                    if="${ipv6 == 'enabled'}" />
>
> To confirm this, the most recent *non-ipv6* build says "ipv6 enabled" in 
> About:
>
> https://osdn.net/projects/tortoisesvn/storage/1.14.3/Application/TortoiseSVN-1.14.3.29387-x64-svn-1.14.2.msi
> [image: image.png]
>
> Maybe the script could be updated to disable IPv6 as originally intended.
>
> Or maybe there is no real problem in enabling IPv6, because the change
> happened 5 years ago in TSVN 1.10.0, and apparently it hasn't been causing
> issues for the users. If so, it might make sense to keep IPv6 enabled in 
> the
> mainstream builds and remove the non-ipv6/ipv6 distinction.
>
> Anyway, reporting this discrepancy just in case…
>
>
> Thanks,
> Evgeny Kotkov
>

-- 
You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn-dev/bf0a6fd9-6608-47df-9fa0-0da194933115n%40googlegroups.com.