Nightlies build failure
Daniel Sahlberg via TortoiseSVN-dev <[email protected]> Sun, 10 Jul 2022 08:09:04 -0700 (PDT)
| Newsgroups | gmane.comp.version-control.subversion.tortoisesvn.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi, The nightly builds are currently failing with the following message: [exec] C:\TSVN\tortoisesvn\ext\TortoisePlink\defs.h(22,1): fatal error C1189: #error: Do not compile this code base with NDEBUG defined! [C:\TSVN\tortoisesvn\ext\TortoisePlink\windows\TPlink\TortoisePlink.vcxproj] [exec] TortoisePlink.c I believe this is caused by a change to defs.h in r29425 which adds a change from upstream (97f7a7cb4deacbc92a9dbdc1b9394e4e1358e47a) enforcing that NDEBUG is not defined. As far as I can see this code was added upstream in PuTTY 0.75 (which was added to TSVN in r29211), but I assume that code was manually deleted from defs.h before committing r29211. I don't know enough about NDEBUG to dare touching this part of the code. I guess we should either remove the #error from defs.h via TortoisePlink.patch or change something to not compile TortoisePlink with NDEBUG. Kind regards, Daniel -- You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn-dev/04b4abb2-15c9-46ea-b139-e16a045b5293n%40googlegroups.com.