[PATCH] Fix: TortoiseSVN (trunk) displays "fetching text bases" notifications incorrectly

Denis Kovalchuk via TortoiseSVN-dev <[email protected]> Tue, 15 Aug 2023 08:00:48 -0700 (PDT)
Newsgroups gmane.comp.version-control.subversion.tortoisesvn.devel
Message-ID <[email protected]>
Hi!

I've noticed that TortoiseSVN (trunk) displays "fetching text bases"
notifications incorrectly when working with a working copy that does not 
store
local copies of pristine contents. See incorrect-notifications.png in the
attachments.

Steps to reproduce:
1. Open TortoiseSVN Checkout dialog box.
2. Uncheck the "Store pristine copies in working copy" checkbox.
3. Check out a working copy.
4. Delete any files using "TortoiseSVN > Delete".
5. Revert local changes using "TortoiseSVN > Revert".

This happens because TortoiseSVN builds with Subversion 1.15-dev, but does 
not
handle the new hydration notifications (svn_wc_notify_hydrating_start,
svn_wc_notify_hydrating_file, svn_wc_notify_hydrating_end) added in 
r1905955 [1].

svn.exe currently handles these notifications in the following way, where 
each
dot indicates one fetched file:

"Fetching text bases .........done."

I've attached a patch that adds handling of these notifications in a similar
manner (see fetching-text-bases.gif images in the attachments):

"Fetching text bases | N files"

[1] https://svn.apache.org/viewvc?view=revision&revision=1905955

Best Regards,
Denis Kovalchuk

-- 
You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn-dev/ec3727fe-736a-48d7-b050-68df9b44c6bcn%40googlegroups.com.
fetching-text-bases-revert-command.png (image/png, 81.7 KB) - not displayed
fetching-text-bases.gif (image/gif, 584.5 KB) - not displayed
incorrect-notifications.png (image/png, 74.9 KB) - not displayed