Re: SVN::GetRootAndHead

Daniel Sahlberg via TortoiseSVN-dev <[email protected]> Wed, 1 May 2024 11:04:50 -0700 (PDT)
Newsgroups gmane.comp.version-control.subversion.tortoisesvn.devel
Message-ID <[email protected]>
------=_Part_102_508257052.1714586690109
Content-Type: multipart/alternative; 
	boundary="----=_Part_103_1714569135.1714586690109"

------=_Part_103_1714569135.1714586690109
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

onsdag 1 maj 2024 kl. 11:29:44 UTC+2 skrev Daniel Sahlberg:

Den m=C3=A5n 29 apr. 2024 kl 19:28 skrev Stefan via TortoiseSVN-dev <
[email protected]>:

would it work if we do both?

            rev =3D cachedProperties.GetHeadRevision(uuid, path);
            if ((rev =3D=3D NO_REVISION) || (m_err !=3D nullptr))
            {
                svn_error_clear(m_err);
                rev =3D cachedProperties.GetHeadRevision(uuid, url);
            }
I don't have a setup ready to test this. At least it would be better than=
=20
before:
- if the path doesn't exist anymore, we try again with the root
- if root works, fine
- if root doesn't work either, it's no worse than before


Stefan


Agree with you that it's no worse than before. It seems to work in my=20
testing. I've committed as r29691.

I've also asked on the subversion dev@ mailing list.

Kind regards,
Daniel


Turned out to be my fault altogether, based in r29499. I've reverted=20
everything and will circle back to the original project monitor issue.=20

--=20
You received this message because you are subscribed to the Google Groups "=
TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/=
tortoisesvn-dev/d821caf4-bf68-40f1-b6ac-6e1808ef42c3n%40googlegroups.com.

------=_Part_103_1714569135.1714586690109
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div><div dir=3D"auto">onsdag 1 maj 2024 kl. 11:29:44 UTC+2 skrev Daniel Sa=
hlberg:<br /></div><blockquote style=3D"margin: 0px 0px 0px 0.8ex; border-l=
eft: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div dir=3D"ltr"><di=
v dir=3D"ltr"><div dir=3D"ltr">Den m=C3=A5n 29 apr. 2024 kl 19:28 skrev Ste=
fan via TortoiseSVN-dev &lt;<a href=3D"" rel=3D"nofollow">tortois...@google=
groups.com</a>&gt;:<br /></div></div></div><div dir=3D"ltr"><div dir=3D"ltr=
"><div><blockquote style=3D"margin: 0px 0px 0px 0.8ex; border-left: 1px sol=
id rgb(204, 204, 204); padding-left: 1ex;">would it work if we do both?<div=
><br /></div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 rev =3D cachedP=
roperties.GetHeadRevision(uuid, path);<br />=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 if ((rev =3D=3D NO_REVISION) || (m_err !=3D nullptr))<br />=C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {<br />=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 svn_error_clear(m_err);<br />=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 rev =3D cachedProperties.GetHeadRevi=
sion(uuid, url);<br />=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }</div><div=
>I don't have a setup ready to test this. At least it would be better than =
before:</div><div>- if the path doesn't exist anymore, we try again with th=
e root</div><div>- if root works, fine</div><div>- if root doesn't work eit=
her, it's no worse than before</div></blockquote><blockquote style=3D"margi=
n: 0px 0px 0px 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-le=
ft: 1ex;"><div><br /></div><div>Stefan</div>

<p></p>

</blockquote><div><br /></div></div></div></div><div dir=3D"ltr"><div dir=
=3D"ltr"><div><div>Agree with you that it's no worse than before. It seems =
to work in my testing. I've committed as r29691.</div><div><br /></div><div=
>I've also asked on the subversion dev@ mailing list.</div><div><br /></div=
><div>Kind regards,</div><div>Daniel</div><div><br /></div></div></div></di=
v></blockquote><div><br /></div><div>Turned out to be my fault altogether, =
based in r29499. I've reverted everything and will circle back to the origi=
nal project monitor issue.=C2=A0</div></div>

<p></p>

-- <br />
You received this message because you are subscribed to the Google Groups &=
quot;TortoiseSVN-dev&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]">tor=
[email protected]</a>.<br />
To view this discussion on the web visit <a href=3D"https://groups.google.c=
om/d/msgid/tortoisesvn-dev/d821caf4-bf68-40f1-b6ac-6e1808ef42c3n%40googlegr=
oups.com?utm_medium=3Demail&utm_source=3Dfooter">https://groups.google.com/=
d/msgid/tortoisesvn-dev/d821caf4-bf68-40f1-b6ac-6e1808ef42c3n%40googlegroup=
s.com</a>.<br />

------=_Part_103_1714569135.1714586690109--

------=_Part_102_508257052.1714586690109--