Re: r29665 causing issue with piped diff

------=_Part_71355_1873707954.1720030847785
Content-Type: multipart/alternative; 
	boundary="----=_Part_71356_216969799.1720030847785"

------=_Part_71356_216969799.1720030847785
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

onsdag 3 juli 2024 kl. 18:56:09 UTC+2 skrev Stefan:

On Wednesday, July 3, 2024 at 3:40:54=E2=80=AFPM UTC+2 [email protected]=
m wrote:

Maybe a check for GetLastError() =3D=3D ERROR_BROKEN_PIPE? I can't figure o=
ut=20
from the documentation for ReadFile [4] how to detect EOF for a pipe.


Yes, that's the correct solution. Because when piping, the pipe gets broken=
=20
when the source process (e.g. git.exe when doing a 'git diff |=20
tortoiseudiff.exe') ends.

I'll commit a fix soon.


r29700 works fine. Thanks!

Kind regards,
Daniel

--=20
You received this message because you are subscribed to the Google Groups "=
TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/=
tortoisesvn-dev/03642485-73ef-4d4e-b5cb-a3a5730eb166n%40googlegroups.com.

------=_Part_71356_216969799.1720030847785
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div><div dir=3D"auto">onsdag 3 juli 2024 kl. 18:56:09 UTC+2 skrev Stefan:<=
br /></div><blockquote style=3D"margin: 0px 0px 0px 0.8ex; border-left: 1px=
 solid rgb(204, 204, 204); padding-left: 1ex;"><div><div dir=3D"auto">On We=
dnesday, July 3, 2024 at 3:40:54=E2=80=AFPM UTC+2 <a href=3D"" rel=3D"nofol=
low">[email protected]</a> wrote:<br /></div><blockquote style=3D"margi=
n: 0px 0px 0px 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-le=
ft: 1ex;">Maybe a check for GetLastError() =3D=3D ERROR_BROKEN_PIPE? I can'=
t figure out from the documentation for ReadFile [4] how to detect EOF for =
a pipe.<br /></blockquote></div><div><div><br /></div></div><div><div>Yes, =
that's the correct solution. Because when piping, the pipe gets broken when=
 the source process (e.g. git.exe when doing a 'git diff | tortoiseudiff.ex=
e') ends.</div><div><br /></div><div>I'll commit a fix soon.</div></div></b=
lockquote><div><br /></div><div>r29700 works fine. Thanks!</div><div><br />=
</div><div>Kind regards,</div><div>Daniel</div></div>

<p></p>

-- <br />
You received this message because you are subscribed to the Google Groups &=
quot;TortoiseSVN-dev&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]">tor=
[email protected]</a>.<br />
To view this discussion on the web visit <a href=3D"https://groups.google.c=
om/d/msgid/tortoisesvn-dev/03642485-73ef-4d4e-b5cb-a3a5730eb166n%40googlegr=
oups.com?utm_medium=3Demail&utm_source=3Dfooter">https://groups.google.com/=
d/msgid/tortoisesvn-dev/03642485-73ef-4d4e-b5cb-a3a5730eb166n%40googlegroup=
s.com</a>.<br />

------=_Part_71356_216969799.1720030847785--

------=_Part_71355_1873707954.1720030847785--