Re: More regarding the Don't show context menu

------=_Part_307898_1113711231.1726640686751
Content-Type: multipart/alternative; 
	boundary="----=_Part_307899_481570427.1726640686751"

------=_Part_307899_481570427.1726640686751
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

tisdag 17 september 2024 kl. 19:47:03 UTC+2 skrev Stefan:

On Monday, September 16, 2024 at 10:24:26=E2=80=AFPM UTC+2 daniel.l...@gmai=
l.com=20
wrote:

Hi,

On investigating the "hang" described in the user's group [1], I checked=20
why TSVN is accessing wc.db even though the working copy path is set as=20
Don't show.

In CShellExt::Initialize, the code is:
For each selected item
  - For item 0: call g_shellCache.IsVersioned
     - Which in turn calls SVNHelper::IsVersioned  <=3D This is accessing=
=20
wc.db
  - Resolve shortcuts, unless we previously found a WC ("shortcut inside a=
=20
working copy should not be resolved so it can be added to version control=
=20
and handled as versioned later")
  - Check if the path is in the Don't show list (ie,=20
g_shellCache.IsContextPathAllowed)

How about moving the call to IsContextPathAllowed to the top of loop? If a=
=20
folder is in the don't show list, then we shouldn't show the context menu=
=20
at all - right?

There should possibly be a separate call to IsContextPathAllowed when a=20
shortcut has been resolved as well to see if the shortcut points to a=20
folder that is in the Don't show list.

WDYT?


I think your analysis is correct. The IsContextPathAllowed should be on top=
=20
of the loop.


Thanks! Committed as r29712.

Cheers,
Daniel

--=20
You received this message because you are subscribed to the Google Groups "=
TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/=
tortoisesvn-dev/a78823bd-0cad-4377-85ac-c768e0ab123cn%40googlegroups.com.

------=_Part_307899_481570427.1726640686751
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div><div dir=3D"auto">tisdag 17 september 2024 kl. 19:47:03 UTC+2 skrev St=
efan:<br /></div><blockquote style=3D"margin: 0px 0px 0px 0.8ex; border-lef=
t: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div><div dir=3D"auto"=
>On Monday, September 16, 2024 at 10:24:26=E2=80=AFPM UTC+2 <a href=3D"" re=
l=3D"nofollow">[email protected]</a> wrote:<br /></div><blockquote styl=
e=3D"margin: 0px 0px 0px 0.8ex; border-left: 1px solid rgb(204, 204, 204); =
padding-left: 1ex;">Hi,<div><br /></div><div>On investigating the "hang" de=
scribed in the user's group [1], I checked why TSVN is accessing wc.db even=
 though the working copy path is set as Don't show.</div><div><br /></div><=
div>In CShellExt::Initialize, the code is:</div><div>For each selected item=
<br /></div><div>=C2=A0 - For item 0: call g_shellCache.IsVersioned</div><d=
iv>=C2=A0 =C2=A0 =C2=A0- Which in turn calls SVNHelper::IsVersioned=C2=A0 &=
lt;=3D This is accessing wc.db</div><div>=C2=A0 - Resolve shortcuts, unless=
 we previously found a WC ("shortcut inside a working copy should not be re=
solved so it can be added to version control and handled as versioned later=
")</div><div>=C2=A0 - Check if the path is in the Don't show list (ie, g_sh=
ellCache.IsContextPathAllowed)</div><div><br /></div><div>How about moving =
the call to IsContextPathAllowed to the top of loop? If a folder is in the =
don't show list, then we shouldn't show the context menu at all - right?</d=
iv><div><br /></div><div>There should possibly be a separate call to IsCont=
extPathAllowed when a shortcut has been resolved as well to see if the shor=
tcut points to a folder that is in the Don't show list.</div><div><br /></d=
iv><div>WDYT?</div><div><br /></div></blockquote><div><br /></div></div><di=
v><div>I think your analysis is correct. The IsContextPathAllowed should be=
 on top of the loop.</div></div></blockquote><div><br /></div><div>Thanks! =
Committed as r29712.</div><div><br /></div><div>Cheers,</div><div>Daniel</d=
iv></div>

<p></p>

-- <br />
You received this message because you are subscribed to the Google Groups &=
quot;TortoiseSVN-dev&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]">tor=
[email protected]</a>.<br />
To view this discussion on the web visit <a href=3D"https://groups.google.c=
om/d/msgid/tortoisesvn-dev/a78823bd-0cad-4377-85ac-c768e0ab123cn%40googlegr=
oups.com?utm_medium=3Demail&utm_source=3Dfooter">https://groups.google.com/=
d/msgid/tortoisesvn-dev/a78823bd-0cad-4377-85ac-c768e0ab123cn%40googlegroup=
s.com</a>.<br />

------=_Part_307899_481570427.1726640686751--

------=_Part_307898_1113711231.1726640686751--