Re: [Trac] patch to run IncludeMacro with Trac 1.6
Jun Omae <[email protected]> Wed, 17 Sep 2025 11:13:03 +0900
| Newsgroups | gmane.comp.version-control.subversion.trac.general |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. --------------LgggkpcQ6HqkewNUgC6W00NV Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks for the feedback. I've committed the patch in=C2=A0[18706] <https://trac-hacks.org/changeset/= 18706>. On 2025/09/14 16:27, Ale=C5=A1 Hor=C3=A1k wrote: > Hi, > > thank you. my patch was the minimum to get it to work, just fixing the er= rors that appeared :-) > > yours is more complete and functional=C2=A0=F0=9F=91=8D > > --=20 > ales horak > > > --=20 > Ale=C5=A1 Hor=C3=A1k > > > ne 14. 9. 2025 v=C2=A05:53 odes=C3=ADlatel Jun Omae <[email protected]> n= apsal: > > Hi, > > On Sat, Sep 13, 2025 at 04:13:16AM -0700, Ales Horak wrote: > > current https://trac-hacks.org/wiki/IncludeMacro does not run under= Trac 1.6 > > due to genshi imports > > > > see the attached patch to make it functional > > > > --=C2=A0 > > ales horak > > Thanks for the patch! However, it seems to be incomplete. > > $ pyflakes includemacro/macros.py > includemacro/macros.py:214:59: undefined name 'TracHTMLSanitizer' > includemacro/macros.py:244:23: undefined name 'ParseError' > includemacro/macros.py:255:27: undefined name 'ParseError' > includemacro/macros.py:288:20: undefined name 'ParseError' > > Could you please try the attached patch? > > --=20 > You received this message because you are subscribed to a topic in th= e Google Groups "Trac Users" group. > To unsubscribe from this topic, visit https://groups.google.com/d/top= ic/trac-users/oIX9bq6TkVc/unsubscribe. > To unsubscribe from this group and all its topics, send an email to t= rac-users+unsubscribe-/[email protected] <mailto:trac-users%2Bunsubscribe@goo= glegroups.com>. > To view this discussion visit https://groups.google.com/d/msgid/trac-= users/aMY8Eia7Pi0d/sOV%40localhost. > > --=20 > You received this message because you are subscribed to the Google Groups= "Trac Users" group. > To unsubscribe from this group and stop receiving emails from it, send an= email to trac-users+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email protected] > To view this discussion visit https://groups.google.com/d/msgid/trac-user= s/CAHm62qP8EwaOVoCpjNiTBThhNNLAs6%2BGGrU6nznXEoX6AOPw7A%40mail.gmail.com <h= ttps://groups.google.com/d/msgid/trac-users/CAHm62qP8EwaOVoCpjNiTBThhNNLAs6= %2BGGrU6nznXEoX6AOPw7A%40mail.gmail.com?utm_medium=3Demail&utm_source=3Dfoo= ter>. --=20 Jun Omae <[email protected]> (=E5=A4=A7=E5=89=8D =E6=BD=A4) --=20 You received this message because you are subscribed to the Google Groups "= Trac Users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to trac-users+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/[email protected] To view this discussion visit https://groups.google.com/d/msgid/trac-users/= 7a15be81-ae58-408a-b5b1-d3740426e65d%40gmail.com. --------------LgggkpcQ6HqkewNUgC6W00NV Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <!DOCTYPE html> <html> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DUTF-8= "> </head> <body> <div class=3D"moz-cite-prefix">Thanks for the feedback.</div> <div class=3D"moz-cite-prefix">I've committed the patch in=C2=A0<a moz-do-not-send=3D"true" href=3D"https://trac-hacks.org/changeset/18706">[18706]</a>.</div> <div class=3D"moz-cite-prefix"><br> </div> <div class=3D"moz-cite-prefix">On 2025/09/14 16:27, Ale=C5=A1 Hor=C3=A1= k wrote:<br> </div> <blockquote type=3D"cite" cite=3D"mid:CAHm62qP8EwaOVoCpjNiTBThhNNLAs6+GGrU6nznXEoX6AOPw7A-JsoAwUIsXotQFR93xxRIaA@public.gmane.org= com"> <meta http-equiv=3D"content-type" content=3D"text/html; charset=3DUTF= -8"> <div dir=3D"ltr">Hi, <div><br> </div> <div>thank you. my patch was the minimum to get it to work, just fixing the errors that appeared :-)</div> <div><br> </div> <div>yours is more complete and functional=C2=A0=F0=9F=91=8D</div> <div><br> </div> <div>-- <br> ales horak<br> </div> <div><br> </div> </div> <div><br clear=3D"all"> </div> <div> <div dir=3D"ltr" class=3D"gmail_signature"> <div dir=3D"ltr">-- <br> Ale=C5=A1 Hor=C3=A1k</div> </div> </div> <br> <br> <div class=3D"gmail_quote gmail_quote_container"> <div dir=3D"ltr" class=3D"gmail_attr">ne 14. 9. 2025 v=C2=A05:53 odes=C3=ADlatel Jun Omae <<a href=3D"mailto:[email protected]" moz-do-not-send=3D"true" class=3D"moz-txt-link-freetext">jun66j= [email protected]</a>> napsal:<br> </div> <blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pa= dding-left:1ex">Hi,<br> <br> On Sat, Sep 13, 2025 at 04:13:16AM -0700, Ales Horak wrote:<br> > current <a href=3D"https://trac-hacks.org/wiki/IncludeMacro" rel=3D"noreferrer" target=3D"_blank" moz-do-not-send=3D"true" class=3D"moz-txt-link-freetext">https://trac-hacks.org/wiki/Inc= ludeMacro</a> does not run under Trac 1.6<br> > due to genshi imports<br> > <br> > see the attached patch to make it functional<br> > <br> > --=C2=A0<br> > ales horak<br> <br> Thanks for the patch! However, it seems to be incomplete.<br> <br> $ pyflakes includemacro/macros.py<br> includemacro/macros.py:214:59: undefined name 'TracHTMLSanitizer'<br> includemacro/macros.py:244:23: undefined name 'ParseError'<br> includemacro/macros.py:255:27: undefined name 'ParseError'<br> includemacro/macros.py:288:20: undefined name 'ParseError'<br> <br> Could you please try the attached patch?<br> <br> -- <br> You received this message because you are subscribed to a topic in the Google Groups "Trac Users" group.<br> To unsubscribe from this topic, visit <a href=3D"https://groups.google.com/d/topic/trac-users/oIX9bq6TkVc/unsubscrib= e" rel=3D"noreferrer" target=3D"_blank" moz-do-not-send=3D"true" class=3D"moz-txt-link-freetext">https://groups.google.com/d/top= ic/trac-users/oIX9bq6TkVc/unsubscribe</a>.<br> To unsubscribe from this group and all its topics, send an email to <a href=3D"mailto:trac-users%2Bunsubscribe-/[email protected]" target=3D"_blank" moz-do-not-send=3D"true">trac-users+unsubscri= be-/[email protected]</a>.<br> To view this discussion visit <a href=3D"https://groups.google.com/d/msgid/trac-users/aMY8Eia7Pi0d/sOV%40loc= alhost" rel=3D"noreferrer" target=3D"_blank" moz-do-not-send=3D"true" class=3D"moz-txt-link-freetext">https://groups.google.com/d/msg= id/trac-users/aMY8Eia7Pi0d/sOV%40localhost</a>.<br> </blockquote> </div> -- <br> You received this message because you are subscribed to the Google Groups "Trac Users" group.<br> To unsubscribe from this group and stop receiving emails from it, send an email to <a href=3D"mailto:trac-users+unsubscribe-/[email protected]" moz-do-not-send=3D"true" class=3D"moz-txt-link-freetext">trac-users= +unsubscribe-/[email protected]</a>.<br> To view this discussion visit <a href=3D"https://groups.google.com/d/msgid/trac-users/CAHm62qP8EwaOVoCpjNiTB= ThhNNLAs6%2BGGrU6nznXEoX6AOPw7A%40mail.gmail.com?utm_medium=3Demail&utm= _source=3Dfooter" moz-do-not-send=3D"true">https://groups.google.com/d/msgid/trac-use= rs/CAHm62qP8EwaOVoCpjNiTBThhNNLAs6%2BGGrU6nznXEoX6AOPw7A%40mail.gmail.com</= a>.<br> </blockquote> <p><br> </p> <pre class=3D"moz-signature" cols=3D"0">--=20 Jun Omae <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:[email protected]= m"><[email protected]></a> (=E5=A4=A7=E5=89=8D =E6=BD=A4)</pre> </body> </html> <p></p> -- <br /> You received this message because you are subscribed to the Google Groups &= quot;Trac Users" group.<br /> To unsubscribe from this group and stop receiving emails from it, send an e= mail to <a href=3D"mailto:trac-users+unsubscribe-/[email protected]">trac-use= rs+unsubscribe-/[email protected]</a>.<br /> To view this discussion visit <a href=3D"https://groups.google.com/d/msgid/= trac-users/7a15be81-ae58-408a-b5b1-d3740426e65d%40gmail.com?utm_medium=3Dem= ail&utm_source=3Dfooter">https://groups.google.com/d/msgid/trac-users/7a15b= e81-ae58-408a-b5b1-d3740426e65d%40gmail.com</a>.<br /> --------------LgggkpcQ6HqkewNUgC6W00NV--