Re: Optimizations, etc.

Am 10.11.06, 06:18 -0500 schrieb Bradley A. Hare:

> Kai-Uwe Behrmann wrote:
> 
> > Your optimisation and suggestions are greatly welcome. Do you like to 
> > create a patch against 0.21-2 for the above mentioned rendering and 
> > manipulation code?
> 
> Never done a patch before in my life, but I suppose it might be
> a good time to figure it out.  I'm still playing with the code a bit to
> see if the clipping logic for contrast could be improved.  For the
> color corrector I can probably clean it up to U8, U16 operation for
> now.  I'll need about a week for cleanup and testing.  I'll also need
> some advice as to where to send the results.  The diffs are probably not
> too big, should I post them here as attachments ???

The patches site resides on sourceforge:
http://sourceforge.net/tracker/?group_id=75029&atid=542708
You probably have allready the necessary sf login.

For patches I use mostly context diffs with the option 
"diff -Nur original.file_or_dir modification.file_or_dir".

It should be quite simple beside many nonsense introduced while scanning 
over directories. The following options may help reducing such:

-x '*.glade' -x '*.Plo' -x \*.Po -x \*.o -x \*.a -x \*.so.\* -x \*.lo 
-x Makefile -x Makefile.in -x \*.la -x \*.lai -x \*.al -x CVS -x \*.rej 
-x '*.diff' -x '*.c_*' -x '*.h_*' -x '*.patch' -x '*.orig' -x '*.swp' 
-x *.loT -x '.libs' -x '.deps' -x '*.po' -x '*.gmo' -x \*.mo -x '*.pot' 
-x POTFILES -x autom4te.cache -x config.log -x config.status -x configure 
-x cinepaint -x cinepaint-remote -x cinepainttool -x cinepaint.spec 
-x gimprc -x config.h -x libtool 
-x \*.tar.gz -x \*.tar.gz_* -x\*.tgz -x \*.rpm

... best to put into a file.

> > For tiff I would be interessted to see a reproducible scenario. A 
> > patch is welcome as well ;-) Otherwise I remain a bit in darkness.
> > 
> 
> The bug came up while I was cleaning up a batch of about 400 images last 
> week (Canon EOS-1ds MkII, raw conversions to 16 bit tiff). I
> have not yet had time to go back and figure out what happened.
> Midway through the retouching ( #&*$#! dust removal) I found a few files
> that would not read back in without a crash.  They also had weird sizes,
> about 130Mb vs 98Mb expected.  Reproducing the problem was difficult. I
> solved the problem by going back to 0.19 - no instances of corrupt files
> (I never made it to 0.20).  I should add one note that I just thought
> of - the files were created with my own version of dcraw that was
> patched up to write tiff (no longer needed as the author has included
> tiff in the latest version).  I will need to make  sure that my files
> were not triggering the bug (They do seem to work without problems in
> Gwenview and XV).

Well, I rely on dcraw 8.37+ as stated in the release notes. It could be a 
reason because rawphoto uses entyrely the tiff output of dcraw now (with 
the appropriate options). 
As well it lets convert to ProPhotoRGB primaries by default. David decided 
to leave in 1.0 gamma space. Thats maybe worth a note. The older rawphoto 
version did apply gamma allready at loadtime.

If it still crashes let us know.

> In the meantime I wanted to use my old notebook to demo the work, hence

Interessting ... ~100Mb images on a notebook?

> my sudden interest in speeding things up.  I'll finish the work in
> progress to apply against 0.21 and then I'll return to the tiff problem.
> 
> I really think that the existing gtk branch of Cinepaint is an
> unrecognized gem and I really need to add a note of thanks to
> everyone who has contributed to the project.  You pretty much
> saved me from defecting to OSX (now if I could just get my
> hands on an open source final-cut pro...)  I'm not into heavily
> photoshopped images so the complaints one hears
> about the feature set are pretty much meaningless to me.  As long as I
> can do what I used to do in the darkroom I'm happy.  Cinepaint gives me
> that and much more.   I also have a "gut" feeling that any existing
> problems can be easily cleaned up.  I'll be keeping gdb warmed up for
> anything that crops up.

Thanks for the kudos :-)

regards
Kai-Uwe Behrmann
                                + development for color management 
                                + imaging / panoramas
                                + email: [email protected]
                                + http://www.behrmann.name


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642