[ cinepaint-Bugs-1828082 ] Public header files should not include config.h.

Bugs item #1828082, was opened at 2007-11-08 05:59
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=542706&aid=1828082&group_id=75029

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Niels Kristian Bech Jensen (nkbj)
Assigned to: Nobody/Anonymous (nobody)
Summary: Public header files should not include config.h.

Initial Comment:
The public header files installed with the CinePaint library for plug-in development should not include the autoconf generated config.h header file since it inteferes with other use of autoconf generating warnings like these:

In file included from /usr/local/include/cinepaint/float16.h:22,
                 from /usr/local/include/cinepaint/plugin_main.h:29,
                 from ufraw-gimp.c:28:
/usr/local/include/cinepaint/config.h:144:1: warning: "PACKAGE" redefined
In file included from ufraw-gimp.c:19:
config.h:95:1: warning: this is the location of the previous definition
In file included from /usr/local/include/cinepaint/float16.h:22,
                 from /usr/local/include/cinepaint/plugin_main.h:29,
                 from ufraw-gimp.c:28:
/usr/local/include/cinepaint/config.h:164:1: warning: "VERSION" redefined
In file included from ufraw-gimp.c:19:
config.h:116:1: warning: this is the location of the previous definition
In file included from /usr/local/include/cinepaint/libgimp/gimpintl.h:28,
                 from /usr/local/include/cinepaint/intl.h:25,
                 from /usr/local/include/cinepaint/libgimp/gimp1.2.h:16,
                 from /usr/local/include/cinepaint/libgimp/gimp.h:14,
                 from /usr/local/include/cinepaint/plugin_main.h:32,
                 from ufraw-gimp.c:28:
./config.h:95:1: warning: "PACKAGE" redefined
In file included from /usr/local/include/cinepaint/float16.h:22,
                 from /usr/local/include/cinepaint/plugin_main.h:29,
                 from ufraw-gimp.c:28:
/usr/local/include/cinepaint/config.h:144:1: warning: this is the location of the previous definition
In file included from /usr/local/include/cinepaint/libgimp/gimpintl.h:28,
                 from /usr/local/include/cinepaint/intl.h:25,
                 from /usr/local/include/cinepaint/libgimp/gimp1.2.h:16,
                 from /usr/local/include/cinepaint/libgimp/gimp.h:14,
                 from /usr/local/include/cinepaint/plugin_main.h:32,
                 from ufraw-gimp.c:28:
./config.h:116:1: warning: "VERSION" redefined
In file included from /usr/local/include/cinepaint/float16.h:22,
                 from /usr/local/include/cinepaint/plugin_main.h:29,
                 from ufraw-gimp.c:28:
/usr/local/include/cinepaint/config.h:164:1: warning: this is the location of the previous definition


Currently (CinePaint 0.22-1) gimpintl.h and float16.h includes config.h.

Regards,
Niels Kristian


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=542706&aid=1828082&group_id=75029

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/