Re: Crash on feather under amd64

Am 08.06.08, 17:39 +0200 schrieb Milan Knížek:
> Kai-Uwe Behrmann píše v Pá 06. 06. 2008 v 19:47 +0200:
> > Am 06.06.08, 16:18 +0200 schrieb Milan Knížek:
> > > I have a long time problem with application of feather to a selection -
> > > CinePaint crashes.
> > 
> > > Is anybody else using CinePaint (CVS) on amd64 linux architecture? (See
> > > bug 1627319 on sourceforge of cinepaint.)

> > can you configure CinePaint with --enable-debug to activate the -g 
> > compiler flag for embedding debug symbols? After that the valgrind output 
> > should be more useful.
> 
> The original compilation log shows that I have used --enable-debug and
> yet gdb did not show much. I am not sure about my updated post to the
> bug tracker with the valgrind output, hence I have compiled cinepaint
> again - I used the version from CVS as of 2008-04-27 since the
> compilation of the current version ends with error of missing oyranos (I
> guess).

Yes, you are correct. Only the valgrind output was missed at that stage. 
Sorry to have overseen that.
 
> The logs (configuration, compilation, installation, valgrind) are
> gzipped on my website (I can upload it to the bug tracker if it proves
> useful):
> 
> http://www.milan-knizek.net/files/tmp/cinepaint_feather_crash.tar.gz

Beside lots of Gtk messages in valgrind I am not shure what to fix.

Anyway attached comes a patch to be applied in app/depth. Hopefully it 
gives valgrind a more clear field of view.

kind regards
Kai-Uwe Behrmann
-- 
developing for colour management 
www.behrmann.name + www.oyranos.org

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

_______________________________________________
Cinepaint-developers mailing list
Cinepaint-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/cinepaint-developers

diff -r1.10 paint_funcs_area.c
180c180
< static gdouble   cubic                     (gdouble, gdouble, gdouble, gdouble,
---
> static inline gdouble   cubic              (gdouble, gdouble, gdouble, gdouble,
1997c1997
< 
---
>   fprintf(stderr, "%s:%d length:%d\n", __FILE__,__LINE__,length);
2002c2002
<     sum[i] = curve[i-length-1] + sum[i-1];
---
>     sum[i] = curve[i-1] + sum[i-1];
2015c2015
<   rle_count = g_malloc (sizeof (int) * MAXIMUM (width, height)); 
---
>   rle_count = g_malloc (sizeof (gint) * MAXIMUM (width, height)); 
2062c2062
<     g_free (curve - length);
---
>     g_free (curve);
5313c5313
<   int i, n;
---
>   gint i, n;
5323c5323
< 
---
>   fprintf(stderr, "%s:%d n:%d\n", __FILE__,__LINE__,n);
5325,5326c5325
<   curve += *length;
<   curve[0] = 1.0;
---
>   curve[*length] = 1.0;
5331,5332c5330,5331
<       curve[-i] = temp;
<       curve[i] = temp;
---
>       curve[*length + i] = temp;
>       curve[*length - i] = temp;