Re: [PATCH v5 4/4] rust: clk: use 'kernel vertical style' for imports
"Alexandre Courbot" <[email protected]>
| Newsgroups | gmane.linux.pwm,gmane.linux.power-management.general,gmane.linux.kernel,gmane.comp.video.dri.devel,gmane.linux.ports.riscv,gmane.linux.kernel.clk,gmane.linux.kernel.rust |
|---|---|
| Message-ID | <[email protected]> |
On Mon Jul 6, 2026 at 11:37 PM JST, Daniel Almeida wrote: > Convert all imports to use the new import style. This will make it easier > to land new changes in the future. > > No change of functionality implied. > > Link: https://docs.kernel.org/rust/coding-guidelines.html#imports > Signed-off-by: Daniel Almeida <[email protected]> Reviewed-by: Alexandre Courbot <[email protected]> Would ideally be the first patch of the series to avoid churn. One small comment below. <...> > @@ -193,9 +203,15 @@ impl<State: ClkState> From<Error<State>> for kernel::error::Error { > /// original [`Clk`], e.g.: > /// > /// ``` > - /// use kernel::clk::{Clk, Enabled, Unprepared}; > - /// use kernel::device::{Bound, Device}; > - /// use kernel::error::Result; > + /// use kernel::clk::{ > + /// Clk, > + /// Enabled, > + /// Unprepared, // Doctests aren't reformatted by `rustfmt` and don't need the trailing `//`.