Re: [PATCH v2] drm/omap: dsi: do not copy isr table
Tomi Valkeinen <[email protected]> Tue, 4 Aug 2026 14:08:35 +0300
| Newsgroups | gmane.linux.kernel,gmane.comp.video.dri.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi, On 04/08/2026 11:49, Andreas Kemnade wrote: > On Wed, 29 Jul 2026 11:23:21 +0300 > Tomi Valkeinen <[email protected]> wrote: > >> Hi, >> >> On 02/07/2026 18:27, Andreas Kemnade wrote: >>> To te able to unregister stuff from isrs, the corresponding table was >>> copied. Nobody seems to unregister stuff that way, so it does not help. >>> But there are stack-allocated objects passed to these isrs giving chances >>> of UAF of these objects if irqs are unregistered while they are handled, >>> so better do not copy that table. >>> >>> Fixes: 4ae2ddddf44cd ("OMAP: DSS2: DSI: Add ISR support") >>> Signed-off-by: Andreas Kemnade <[email protected]> >>> --- >>> If this gets backported, it should be re-checked that >>> no isr unregisters itself in older kernel versions`. >>> --- >>> Changes in v2: >>> - remove variable definition (Sashiko) >>> - Link to v1: https://patch.msgid.link/[email protected] >> >> Looks good to me, applying to drm-misc-next. >> > It seems not to be on linux-next. somehow this did fall through the cracks? It did. I applied it to my local dim branch, then went looking for other omapdrm patches (the dsi one), which took a while and... yes, forgot to push... Pushed now to drm-misc-next. Tomi