Re: [PATCH v2 42/46] dt-bindings: display: mediatek: Introduce MT8196 2D Sharpness Processor

On Tue, Jul 28, 2026 at 8:49=E2=80=AFAM AngeloGioacchino Del Regno
<angelogioacchino.delregno-ZGY8ohtN/[email protected]> wrote:
>
> On 7/28/26 15:40, Rob Herring wrote:
> > On Tue, Jul 14, 2026 at 6:45=E2=80=AFAM AngeloGioacchino Del Regno
> > <angelogioacchino.delregno-ZGY8ohtN/[email protected]> wrote:
> >>
> >> Add documentation for the Two-Dimension Sharpness Processor, or
> >> "TDSHP", found in many MediaTek SoCs including MT8196 and its
> >> variants.
> >>
> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@c=
ollabora.com>
> >> ---
> >>   .../mediatek/mediatek,mt8196-tdshp.yaml       | 98 +++++++++++++++++=
++
> >>   1 file changed, 98 insertions(+)
> >>   create mode 100644 Documentation/devicetree/bindings/display/mediate=
k/mediatek,mt8196-tdshp.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediat=
ek,mt8196-tdshp.yaml b/Documentation/devicetree/bindings/display/mediatek/m=
ediatek,mt8196-tdshp.yaml
> >> new file mode 100644
> >> index 000000000000..ccd6a8443443
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,mt81=
96-tdshp.yaml
> >> @@ -0,0 +1,98 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/display/mediatek/mediatek,mt8196-t=
dshp.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: MediaTek Display Two-Dimension Sharpness Processor (TDSHP)
> >> +
> >> +maintainers:
> >> +  - AngeloGioacchino Del Regno <[email protected]=
om>
> >> +
> >> +description:
> >> +  The MediaTek 2D Sharpness Processor (TDSHP) is responsible for perf=
orming
> >> +  image sharpness adjustments/enhancements in a display pipeline.
> >> +  This hardware block supports adjusting the luma and contour 2d hist=
ograms,
> >> +  frequency weighting, luma-chroma gain and others, with adaptive wei=
ghts.
> >> +
> >> +properties:
> >> +  compatible:
> >> +    const: mediatek,mt8196-disp-tdshp
> >> +
> >> +  reg:
> >> +    maxItems: 1
> >> +
> >> +  clocks:
> >> +    maxItems: 1
> >> +
> >> +  power-domains:
> >> +    maxItems: 1
> >> +
> >> +  ports:
> >> +    $ref: /schemas/graph.yaml#/properties/ports
> >> +
> >> +    properties:
> >> +      port@0:
> >> +        $ref: /schemas/graph.yaml#/properties/port
> >> +
> >> +      port@1:
> >> +        $ref: /schemas/graph.yaml#/properties/port
> >> +
> >> +    required:
> >> +      - port@0
> >> +      - port@1
> >> +
> >> +  trigger-sources:
> >> +    maxItems: 1
> >> +
> >> +required:
> >> +  - compatible
> >> +  - reg
> >> +  - clocks
> >> +  - clock-names
> >
> > This causes a warning.
> >
> > Seems this is in linux-next already, but no reviews?
> >
> > Rob
>
> Wow. No idea how clock-names got into the list of required properties: th=
ere is
> only one possible clock, and this doesn't need any clock-names at all.
>
> Same for the resizer binding.
> Sorry for the mistake.

Why is this still in linux-next?

Rob