Re: [PATCH v2 1/6] dt-bindings: display: add a device tree supplied boot logo
MÃ xim Pedraza Padilla <[email protected]> Thu, 6 Aug 2026 03:20:03 +0200
| Newsgroups | gmane.linux.kernel,gmane.comp.video.dri.devel,gmane.linux.drivers.devicetree |
|---|---|
| Message-ID | <CAEUXW=GWjTSoa6iRcA=AsP1xkKdud_rwYvgqXahmzHBYZDPYyA@mail.gmail.com> |
> Documentation/.../linux,boot-logo-clut224.example.dtb: /: 'compatible' > is a required property > Documentation/.../linux,boot-logo-clut224.example.dtb: /: 'model' is a > required property Fixed in v3: the example now declares compatible and model on the root node, the way the simple-framebuffer example does. > Documentation/.../linux,boot-logo-clut224.example.dtb: chosen: 'logo' > does not match any of the regexes: '^framebuffer', '^pinctrl-[0-9]+$' This one cannot be fixed in the binding: chosen.yaml allows only ^framebuffer under /chosen, so any node this binding describes is rejected wherever it appears. I have opened a pull request against dt-schema adding '^logo$' alongside it: https://github.com/devicetree-org/dt-schema/pull/204 It mirrors how framebuffer is handled: the entry is just "true", with the contents validated by this binding through the compatible string. The pattern is anchored because the node carries no reg and so has no unit address, and the binding pins the name with $nodename: const: logo. If the naming changes as a result of your other question, the pull request follows it; it is one line. With that applied, a full 'make dt_binding_check' is clean for this schema. Without it, the third error above stands, so this series depends on that pull request. I did not see any of the three locally because I had been running with DT_SCHEMA_FILES set, which leaves root-node.yaml and chosen.yaml out of the processed schema entirely. Your message says exactly that; I should have read it before rather than after. Running it unset now. > The base for the series is generally the latest rc1. A different > dependency should be noted in *this* patch. Noted. The base is Linus' master, currently v7.2-rc6, at Helge's request: v1 went out based on a stable release and did not apply to any tree he uses, so he asked for git head. v3 carries a base-commit: trailer from git format-patch --base= so the exact commit is recorded in the series. Happy to rebase onto rc1 if you would rather have that. Max