[PATCH v3 3/5] drm/bridge: nwl-dsi: Correct auto-insert EOTP behavior
Esben Haabendal <[email protected]>
| Newsgroups | gmane.linux.kernel.stable,gmane.comp.video.dri.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
From: Robert Chiras <[email protected]> In order to respect the DSI protocol, make sure that auto-insert EOTP is enabled according to the NO_EOT_PACKET flag instead of the CLOCK_NON_CONTINUOUS flag. Fixes: 44cfc6233447 ("drm/bridge: Add NWL MIPI DSI host controller support") Cc: [email protected] Signed-off-by: Esben Haabendal <[email protected]> Cc: Robert Chiras <[email protected]> Cc: Laurentiu Palcu <[email protected]> --- drivers/gpu/drm/bridge/nwl-dsi.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c index 374884e76f25..3fd41212933c 100644 --- a/drivers/gpu/drm/bridge/nwl-dsi.c +++ b/drivers/gpu/drm/bridge/nwl-dsi.c @@ -222,13 +222,15 @@ static int nwl_dsi_config_host(struct nwl_dsi *dsi) DRM_DEV_DEBUG_DRIVER(dsi->dev, "DSI Lanes %d\n", dsi->lanes); nwl_dsi_write(dsi, NWL_DSI_CFG_NUM_LANES, dsi->lanes - 1); - if (dsi->dsi_mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) { + if (dsi->dsi_mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) nwl_dsi_write(dsi, NWL_DSI_CFG_NONCONTINUOUS_CLK, 0x01); - nwl_dsi_write(dsi, NWL_DSI_CFG_AUTOINSERT_EOTP, 0x01); - } else { + else nwl_dsi_write(dsi, NWL_DSI_CFG_NONCONTINUOUS_CLK, 0x00); + + if (dsi->dsi_mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET) nwl_dsi_write(dsi, NWL_DSI_CFG_AUTOINSERT_EOTP, 0x00); - } + else + nwl_dsi_write(dsi, NWL_DSI_CFG_AUTOINSERT_EOTP, 0x01); /* values in byte clock cycles */ cycles = ui2bc(cfg->clk_pre); -- 2.55.0