Re: [PATCH v2 4/5] drm/amdgpu: skip amdgpu_gart_unbind if the device is wedged

On 8/13/26 19:07, Pierre-Eric Pelloux-Prayer wrote:
> This operation requires access to the GPU.
> 
> Signed-off-by: Pierre-Eric Pelloux-Prayer <[email protected]>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c
> index c4c21dbbbdbf..09ddfccb8174 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c
> @@ -315,7 +315,7 @@ void amdgpu_gart_unbind(struct amdgpu_device *adev, uint64_t offset,
>  	uint64_t flags = 0;
>  	int idx;
>  
> -	if (!adev->gart.ptr)
> +	if (!adev->gart.ptr || amdgpu_device_is_wedged(adev))

That is a good start but certainly not sufficient.

We need that on every occasion drm_dev_enter() is called in the driver.

Regards,
Christian.

>  		return;
>  
>  	if (!drm_dev_enter(adev_to_drm(adev), &idx))