Re: [PATCH] drm/sched: Lock drm_sched_entity_is_idle()

Philipp Stanner <[email protected]>
Newsgroups gmane.linux.kernel,gmane.comp.video.dri.devel
Message-ID <[email protected]>
On Thu, 2026-08-13 at 11:37 +0100, Tvrtko Ursulin wrote:
> 
> On 13/08/2026 10:45, Philipp Stanner wrote:
> > drm_sched_entity_is_idle() contains a badly documented memory barrier
> > and an invalid lockless access to entity->stopped. Moreover, it also
> > accesses entity->list which is at all other places protected by
> > entity->lock.
> > 
> > This function is in no way performance critical, so it is safer, more
> > readable and more maintainable to take the spinlock.
> > 
> > Add locking to drm_sched_entity_is_idle().
> > 
> 

[…]

> Spotted by chance on the mailing list but I believe I gave you r-b for 
> this one already.

Applied to misc-next with your r-b.

Thx
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.