Re: Patch: add "auto clip only" as a zoom/clip preset

Jörn Reder wrote:
> 
> Hmm, it also adds AC3 passthrough and 192kb audio bitrate by default, 
> but Ok ;)

Sorry, that was an unrelated change that I made for my own use, didn't 
mean to include it in the patch. A config setting would obviously be the 
right way for me to submit that patch.

> Thanks for your patch. I had to modify it a bit, because the 
> --export_par option has to be set (and probably cleared) everytime the 
> user applies a (another) preset. Also it must take the current 
> resolution (NTSC/PAL) into account, not just the aspect ratio of the 
> original video. As well --export_par should be set if the user decides 
> to keep the original anamorph picture size completely unchanged. In 
> simple words: it has to be used if the user decides not to resize the 
> picture (regardless wether using your new "Autoadjust, Clipping only" 
> preset or not).

Yeah, I kind of figured that that part of the patch wasn't up to snuff 
design-wise. Thanks for thinking that through better instead of just 
rejecting it. :)

I'm not sure how I feel about the single-digit magic number version of 
export_par -- the two-number version self-documents what it's doing 
better, so that the user can tweak it if they want. But that's a minor 
quibble.

One thing I was wondering about -- is 720:(480|576) a universal standard 
for vob files, or should we actually query the real dimensions of the 
vob file and calculate the proper export_par value? I've never seen a 
DVD with non-standard size files, but my collection is small.

> This patch also adds a new preset option "Default Clip & Zoom preset", 
> amongst others to satisfy Mate SOOS being so unsatisfied by transcode's
> fast resizing and the dvd::rip developer's default preset decision ;)

I considered doing that with my patch, but my perl is week, and I wasn't 
100% sure how to add it. Thanks for taking care of it.

> Funny enough, with this --export_par/anamorph patch image resizing is 
> not necessary anymore at all ;) (asuming your player is able to detect 
> the aspect ratio written into the avi/ogg file correctly).

Yup, that was exactly my goal. Clipping only is a lot faster than the HQ 
resizer, and if you're transcoding full size anyway, it doesn't make 
sense to resize.

- Marc