Problem with single audio track projects in a cluster
Matt Lawrence <[email protected]> Sun, 23 Nov 2008 00:49:25 -0500
| Newsgroups | gmane.comp.video.dvdrip.user |
|---|---|
| Message-ID | <[email protected]> |
I've discovered that in 0.98.9, if you have a project with a single audio track in a cluster, there are no guarantees that the full audio track will be merged in with the final video. This is due to the fact that in this situation, the merge-video-chunks job doesn't depend on the audio-track-processing job, so when it performs the merge, it is possible that the audio track hasn't been fully processed (or even processed at all), and thus causes issues with the final output video. The attached patch should resolve the issue. -- Matt Lawrence, President m3lawren at uwaterloo dot ca Computer Science Club http://csclub.uwaterloo.ca/~m3lawren Mathematics Society MC 3036, (519)888-4567,x33870 University of Waterloo Waterloo, Ontario CANADA N2L 3G1
dvdrip-0.98.9-singleaudiodep.patch.txt
(text/plain, 693 B)
Index: lib/Video/DVDRip/Cluster/JobPlanner.pm
===================================================================
RCS file: /cvs/dvdrip/lib/Video/DVDRip/Cluster/JobPlanner.pm,v
retrieving revision 1.3
diff -a -u -r1.3 JobPlanner.pm
--- lib/Video/DVDRip/Cluster/JobPlanner.pm 16 Aug 2006 19:34:38 -0000 1.3
+++ lib/Video/DVDRip/Cluster/JobPlanner.pm 23 Nov 2008 05:48:27 -0000
@@ -132,6 +132,8 @@
if ( $tc_merge_audio_job ) {
$tc_merge_audio_job->set_depends_on([$tc_merge_video_job, $tc_audio_job]);
push @psu_jobs, $tc_merge_audio_job;
+ } elsif ($tc_audio_job) {
+ $tc_merge_video_job->set_depends_on([$tc_audio_job])
}
}