Re: [PATCH] avformat/rtpdec: fix side_data leak when a packet is rejected
曾维宇 via ffmpeg-devel <[email protected]> Mon, 27 Jul 2026 16:41:18 +0800
| Newsgroups | gmane.comp.video.ffmpeg.devel |
|---|---|
| Message-ID | <CANCpdHj0wnYFSCYCVuC-8+v2KJVvf7z0weSR3VkQmxEGRqQoEA@mail.gmail.com> |
U3ViamVjdDogUmU6IFtQQVRDSF0gYXZmb3JtYXQvcnRwZGVjOiBmaXggc2lkZV9kYXRhIGxlYWsg d2hlbiBhIHBhY2tldCBpcw0KcmVqZWN0ZWQNCg0KQVNhbiB2ZXJpZmljYXRpb24gZGV0YWlsICgu L2NvbmZpZ3VyZSAtLXRvb2xjaGFpbj1nY2MtYXNhbjsgbWluaW1hbCBSVFNQDQpzb3VyY2UgaW5q ZWN0aW5nIEguMjY0IE5BTCB0eXBlIDMwIGZvbGxvd2VkIGJ5IGEgdmFsaWQgTkFMLCB4NDAwKToN Cg0KV2l0aG91dCB0aGUgcGF0Y2g6DQogIFNVTU1BUlk6IEFkZHJlc3NTYW5pdGl6ZXI6IDg5NjAw IGJ5dGUocykgbGVha2VkIGluIDEyMDAgYWxsb2NhdGlvbihzKQ0KICAgIERpcmVjdCBsZWFrICAx OTIwMCBCIC8gNDAwIG9iajogYXZfcGFja2V0X25ld19zaWRlX2RhdGENCiAgICAgICAgLT4gcnRw X3NldF9wcmZ0IChydHBkZWMuYzo2MDApDQogICAgICAgIC0+IGZpbmFsaXplX3BhY2tldCAocnRw ZGVjLmM6NjQ1KQ0KICAgICAgICAtPiBydHBfcGFyc2VfcGFja2V0X2ludGVybmFsIChydHBkZWMu Yzo3NTcpDQogICAgICAgIC0+IGZmX3J0cF9wYXJzZV9wYWNrZXQgKHJ0cGRlYy5jOjkzMikNCiAg ICAgICAgLT4gZmZfcnRzcF9mZXRjaF9wYWNrZXQgKHJ0c3AuYzoyNDY1KQ0KICAgIEluZGlyZWN0 IGxlYWsgMzg0MDAgQiAvIDQwMCBvYmo6IHJ0cF9hZGRfc3Jfc2lkZWRhdGEgKHJ0cGRlYy5jOjYx NykNCiAgICAgICAgLT4gZmluYWxpemVfcGFja2V0IChydHBkZWMuYzo2MzQpICAgICAgICBbQVZf UEtUX0RBVEFfUlRDUF9TUl0NCiAgICBJbmRpcmVjdCBsZWFrIDMyMDAwIEIgLyA0MDAgb2JqOiBy dHBfc2V0X3ByZnQgUFJGVCBwYXlsb2FkDQoocnRwZGVjLmM6NjAwKQ0KDQpXaXRoIHRoZSBwYXRj aDogaWRlbnRpY2FsIGlucHV0IC0+IExlYWtTYW5pdGl6ZXIgcmVwb3J0cyB6ZXJvIGxlYWtzLg0K DQp6ZW5nd2VpeXUgPHdvNDU5MzA1NTk1QGdtYWlsLmNvbT4g5LqOMjAyNuW5tDfmnIgyN+aXpeWR qOS4gCAxNjozNOWGmemBk++8mg0KDQo+IEZyb206IOabvue7tOWuhyA8d280NTkzMDU1OTVAZ21h aWwuY29tPg0KPg0KPiBydHBfcGFyc2VfcGFja2V0X2ludGVybmFsKCkgY2FsbHMgZmluYWxpemVf cGFja2V0KCkgdW5jb25kaXRpb25hbGx5IHJpZ2h0DQo+IGFmdGVyIHRoZSBkZXBhY2tldGl6ZXIs IGV2ZW4gd2hlbiB0aGUgbGF0dGVyIHJldHVybmVkIGFuIGVycm9yLg0KPiBmaW5hbGl6ZV9wYWNr ZXQoKSBhdHRhY2hlcyBzaWRlIGRhdGEgdG8gdGhlIHBhY2tldCAtIEFWX1BLVF9EQVRBX1BSRlQg dmlhDQo+IHJ0cF9zZXRfcHJmdCgpIGFuZCBBVl9QS1RfREFUQV9SVENQX1NSIHZpYSBydHBfYWRk X3NyX3NpZGVkYXRhKCkuDQo+DQo+IFRoZSByZWplY3RlZCBwYWNrZXQgaXMgbmV2ZXIgZGVsaXZl cmVkLCBidXQgdGhlIHNhbWUgQVZQYWNrZXQgaXMgcmV1c2VkIGluDQo+IHR3byBwbGFjZXMgd2l0 aG91dCBiZWluZyB1bnJlZmVyZW5jZWQgZmlyc3Q6DQo+DQo+ICAgKiB0aGUgcXVldWUtZHJhaW4g bG9vcCBpbiBmZl9ydHBfcGFyc2VfcGFja2V0KCk6DQo+ICAgICAgICAgd2hpbGUgKHJ2IDwgMCAm JiBoYXNfbmV4dF9wYWNrZXQocykpDQo+ICAgICAgICAgICAgIHJ2ID0gcnRwX3BhcnNlX3F1ZXVl ZF9wYWNrZXQocywgcGt0KTsNCj4gICAqIHRoZSBSVFNQICJyZWRvIiBsb29wIGluIGZmX3J0c3Bf ZmV0Y2hfcGFja2V0KCksIHdoaWNoIHBhcnNlcyB0aGUgbmV4dA0KPiAgICAgUlRQIHBhY2tldCBp bnRvIHRoZSBzYW1lIEFWUGFja2V0IG9uIGVycm9yLg0KPg0KPiBXaGVuIHRoZSBuZXh0IChzdWNj ZXNzZnVsKSBkZXBhY2tldGl6ZXIgdGhlbiBjYWxscyBhdl9uZXdfcGFja2V0KCkgb24gdGhhdA0K PiByZXVzZWQgcGFja2V0LCBnZXRfcGFja2V0X2RlZmF1bHRzKCkgcnVucyBtZW1zZXQocGt0LCAw LCBzaXplb2YoKnBrdCkpLA0KPiB3aGljaCB6ZXJvZXMgcGt0LT5zaWRlX2RhdGEgKGFuZCBzaWRl X2RhdGFfZWxlbXMpIHdpdGhvdXQgZnJlZWluZyBpdC4gVGhlDQo+IHNpZGUgZGF0YSBhdHRhY2hl ZCBieSB0aGUgcHJldmlvdXMsIGZhaWxlZCBmaW5hbGl6ZV9wYWNrZXQoKSBjYWxsIGlzDQo+IHRo ZXJlZm9yZSBsZWFrZWQgLSBvbmUgYWxsb2NhdGlvbiBwZXIgYmFkLT5nb29kIHRyYW5zaXRpb24u DQo+DQo+IEZvciBILjI2NCB0aGlzIGlzIHJlYWNoYWJsZSB3aGVuZXZlciBhIG1hbGZvcm1lZCBO QUwgdW5pdCAodW5kZWZpbmVkIHR5cGUsDQo+IFNUQVAtQi9NVEFQL0ZVLUIsIHRydW5jYXRlZCBG VS1BLCBvdmVyc2l6ZWQgU1RBUC1BIE5BTCwgb3IgZW1wdHkgcGF5bG9hZCkNCj4gYXJyaXZlcyBh ZnRlciB0aGUgZmlyc3QgUlRDUCBTUiwgZm9sbG93ZWQgYnkgYSB2YWxpZCBwYWNrZXQuDQo+DQo+ IEZpeCBpdCBieSB1bnJlZmVyZW5jaW5nIHRoZSBwYWNrZXQgb24gdGhlIGVycm9yIHBhdGgsIGJl Zm9yZQ0KPiBmaW5hbGl6ZV9wYWNrZXQoKQ0KPiBydW5zLCBzbyB0aGUgY2FsbGVyIGFsd2F5cyBv YnNlcnZlcyBhIGNsZWFuIHBhY2tldCByZWdhcmRsZXNzIG9mIHdoYXQgdGhlDQo+IGRlcGFja2V0 aXplciBsZWZ0IGJlaGluZC4NCj4NCj4gVmVyaWZpZWQgd2l0aCBhbiBBU2FuIGJ1aWxkICgtLXRv b2xjaGFpbj1nY2MtYXNhbikgYWdhaW5zdCBhIG1pbmltYWwgUlRTUA0KPiBzb3VyY2UgaW5qZWN0 aW5nIEguMjY0IE5BTCB0eXBlIDMwIGZvbGxvd2VkIGJ5IGEgdmFsaWQgTkFMOiA4OTYwMCBieXRl cyBpbg0KPiAxMjAwIGFsbG9jYXRpb25zIGxlYWtlZCB3aXRob3V0IHRoZSBwYXRjaCwgemVybyB3 aXRoIGl0Lg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiDmm77nu7TlrocgPHdvNDU5MzA1NTk1QGdtYWls LmNvbT4NCj4gLS0tDQo+ICBsaWJhdmZvcm1hdC9ydHBkZWMuYyB8IDEyICsrKysrKysrKysrKw0K PiAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKykNCj4NCj4gZGlmZiAtLWdpdCBhL2xp YmF2Zm9ybWF0L3J0cGRlYy5jIGIvbGliYXZmb3JtYXQvcnRwZGVjLmMNCj4gaW5kZXggNTg3MmMw ZjU5Yy4uYzA3MzZiNTYxOSAxMDA2NDQNCj4gLS0tIGEvbGliYXZmb3JtYXQvcnRwZGVjLmMNCj4g KysrIGIvbGliYXZmb3JtYXQvcnRwZGVjLmMNCj4gQEAgLTc1Myw2ICs3NTMsMTggQEAgc3RhdGlj IGludCBydHBfcGFyc2VfcGFja2V0X2ludGVybmFsKFJUUERlbXV4Q29udGV4dA0KPiAqcywgQVZQ YWNrZXQgKnBrdCwNCj4gICAgICAgICAgcmV0dXJuIEFWRVJST1IoRUlOVkFMKTsNCj4gICAgICB9 DQo+DQo+ICsgICAgaWYgKHJ2IDwgMCkgew0KPiArICAgICAgICAvKiBUaGUgZGVwYWNrZXRpemVy IHJlamVjdGVkIHRoaXMgcGFja2V0OyBpdCB3aWxsIG5vdCBiZQ0KPiBkZWxpdmVyZWQuDQo+ICsg ICAgICAgICAqIFVucmVmZXJlbmNlIHdoYXRldmVyIGl0IG1heSBhbHJlYWR5IGhhdmUgd3JpdHRl biwgYW5kIHByZXZlbnQNCj4gKyAgICAgICAgICogZmluYWxpemVfcGFja2V0KCkgZnJvbSBhdHRh Y2hpbmcgc2lkZSBkYXRhIHRvIGl0LCBzbyBub3RoaW5nIGlzDQo+ICsgICAgICAgICAqIGxlYWtl ZCB3aGVuIHRoZSBwYWNrZXQgaXMgcmV1c2VkLiBCb3RoIHRoZSBSVFNQICJyZWRvIiBwYXRoIGFu ZA0KPiArICAgICAgICAgKiB0aGUgcXVldWUtZHJhaW4gbG9vcCBpbiBmZl9ydHBfcGFyc2VfcGFj a2V0KCkgcmV1c2UgdGhpcw0KPiBBVlBhY2tldCwNCj4gKyAgICAgICAgICogYW5kIGEgbGF0ZXIg YXZfbmV3X3BhY2tldCgpIHdvdWxkIG90aGVyd2lzZSBtZW1zZXQoKSB0aGUNCj4gKyAgICAgICAg ICogc2lkZV9kYXRhIHBvaW50ZXIgYXdheSB3aXRob3V0IGZyZWVpbmcgaXQuICovDQo+ICsgICAg ICAgIGF2X3BhY2tldF91bnJlZihwa3QpOw0KPiArICAgICAgICByZXR1cm4gcnY7DQo+ICsgICAg fQ0KPiArDQo+ICAgICAgLy8gbm93IHBlcmZvcm0gdGltZXN0YW1wIHRoaW5ncy4uLi4NCj4gICAg ICBmaW5hbGl6ZV9wYWNrZXQocywgcGt0LCB0aW1lc3RhbXApOw0KPg0KPiAtLQ0KPiAyLjQyLjAu d2luZG93cy4yDQo+DQo+DQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpmZm1wZWctZGV2ZWwgbWFpbGluZyBsaXN0IC0tIGZmbXBlZy1kZXZlbEBmZm1wZWcu b3JnClRvIHVuc3Vic2NyaWJlIHNlbmQgYW4gZW1haWwgdG8gZmZtcGVnLWRldmVsLWxlYXZlQGZm bXBlZy5vcmcK