[Question] iamf_writer: should the Opus branch override skip_samples from side data?
James A Livingston via ffmpeg-devel <[email protected]> Mon, 27 Jul 2026 20:46:07 -0700
| Newsgroups | gmane.comp.video.ffmpeg.devel |
|---|---|
| Message-ID | <[email protected]> |
SGksDQoNCkkndmUgYmVlbiB0ZXN0aW5nIElBTUYgc3RyZWFtLWNvcHkgYW5kIGhpdCBzb21ldGhp bmcgSSBjYW4ndCB0ZWxsIGlzIGludGVuZGVkLiBJJ2QgcmF0aGVyIGFzayB0aGFuIGZpbGUsIHNp bmNlIEkndmUgYWxyZWFkeSBiZWVuIHdyb25nIG9uY2Ugb24gdGhpcyB0cmFja2VyLg0KDQpTdHJl YW0tY29weWluZyBhbiBJQU1GIGZpbGUgd2l0aCBPcHVzIGVzc2VuY2UgZHJvcHMgbnVtX3NhbXBs ZXNfdG9fdHJpbV9hdF9zdGFydCBmcm9tIHRoZSBBdWRpbyBGcmFtZSBPQlVzLiBUaGUgZGVtdXhl ciByZWFkcyBpdCBjb3JyZWN0bHkg4oCUIGZmcHJvYmUgLXNob3dfcGFja2V0cyByZXBvcnRzIHNr aXBfc2FtcGxlczogMzEyIOKAlCBidXQgaXQgaXNuJ3Qgd3JpdHRlbiBiYWNrIG91dCwgYW5kIHRo ZSBvdXRwdXQgaXMgMjEgYnl0ZXMgc2hvcnRlciAoNyBzdWJzdHJlYW1zIMOXIDMgYnl0ZXM6IHRo ZSB0cmltbWluZyBmbGFnIGNsZWFyZWQsIHR3byBVTEVCMTI4IGZpZWxkcyBkcm9wcGVkKS5udW1f c2FtcGxlc190b190cmltX2F0X2VuZCBzdXJ2aXZlcy4NCg0KVGhlIHJlbGV2YW50IHBhcnQgb2Yg bGliYXZmb3JtYXQvaWFtZl93cml0ZXIuYzoNCg0KYw0KaWYgKHNpZGVfZGF0YSAmJiBzaWRlX2Rh dGFfc2l6ZSA+PSAxMCkgew0KICAgIHNraXBfc2FtcGxlcyAgICA9IEFWX1JMMzIoc2lkZV9kYXRh KTsNCiAgICBkaXNjYXJkX3BhZGRpbmcgPSBBVl9STDMyKHNpZGVfZGF0YSArIDQpOw0KfQ0KDQpp ZiAoY29kZWNfY29uZmlnLT5jb2RlY19pZCA9PSBBVl9DT0RFQ19JRF9PUFVTKSB7DQogICAgLy8g SUFNRidzIG51bV9zYW1wbGVzX3RvX3RyaW1fYXRfc3RhcnQgaXMgdGhlIHNhbWUgYXMgT3B1cydz IHByZS1za2lwLg0KICAgIHNraXBfc2FtcGxlcyA9IHBrdC0+ZHRzIDwgMA0KICAgICAgICA/IGF2 X3Jlc2NhbGUoLXBrdC0+ZHRzLCA0ODAwMCwgcGt0LT50aW1lX2Jhc2UuZGVuKQ0KICAgICAgICA6 IDA7DQogICAgZGlzY2FyZF9wYWRkaW5nID0gYXZfcmVzY2FsZShkaXNjYXJkX3BhZGRpbmcsIDQ4 MDAwLCBwa3QtPnRpbWVfYmFzZS5kZW4pOw0KfQ0KVGhlIGNvbW1lbnQgc3VnZ2VzdHMgdGhlIGlu dGVudCBpcyB0aGF0IHRoZSB2YWx1ZSBpcyBhbHdheXMgdGhlIE9wdXMgcHJlLXNraXAgYW5kIGNh biBiZSByZS1kZXJpdmVkLCB3aGljaCBob2xkcyBvbiB0aGUgZW5jb2RlIHBhdGggd2hlcmUgdGhl IGZpcnN0IERUUyBpcyBuZWdhdGl2ZSBieSB0aGUgZW5jb2RlciBkZWxheS4gT24gY29weSB0aGUg ZGVtdXhlciBnaXZlcyBkdHMgPSAwIGFuZCBwdXRzIHRoZSB2YWx1ZSBpbiBzaWRlIGRhdGEsIHNv IHRoZSBicmFuY2ggeWllbGRzIDAuDQoNCk15IHF1ZXN0aW9uIGlzIHdoZXRoZXIgdGhhdCdzIGRl bGliZXJhdGUuIFR3byB0aGluZ3MgbWFrZSBtZSB1bnN1cmU6DQoNCmRpc2NhcmRfcGFkZGluZyBp biB0aGUgc2FtZSBibG9jayBpcyBvbmx5IHJlc2NhbGVkLCBub3Qgb3ZlcndyaXR0ZW4g4oCUIHNv IGVuZC10cmltIHN1cnZpdmVzIGEgY29weSBhbmQgc3RhcnQtdHJpbSBkb2Vzbid0LCB3aGljaCBy ZWFkcyBtb3JlIGxpa2UgYW4gb3ZlcnNpZ2h0IHRoYW4gYSBydWxlLg0KVGhlIG92ZXJyaWRlIGlz IGluc2lkZSB0aGUgT3B1cyBjYXNlLCBzbyBGTEFDL1BDTS9BQUMgZXNzZW5jZSB3b3VsZCBrZWVw IHRoZSBzaWRlLWRhdGEgdmFsdWUuIFRoYXQgYXN5bW1ldHJ5IHNlZW1zIHVuaW50ZW50aW9uYWwu DQpJZiBudW1fc2FtcGxlc190b190cmltX2F0X3N0YXJ0IGlzIG9ubHkgZXZlciB0aGUgcHJlLXNr aXAsIHRoZW4gbm90aGluZyBpcyBsb3N0IOKAlCBhIGRlY29kZXIgZ2V0cyB0aGUgc2FtZSBudW1i ZXIgZnJvbSB0aGUgY29kZWMgY29uZmlnLCBhbmQgSSd2ZSBjb25maXJtZWQgZmZtcGVnIGRlY29k ZXMgc3VjaCBhIGNvcHkgaWRlbnRpY2FsbHkuIEJ1dCBpZiBpdCBjYW4gbGVnaXRpbWF0ZWx5IGV4 Y2VlZCB0aGUgY29kZWMgZGVsYXkgKGFuIGVkaXQgcG9pbnQsIGNvbmNhdGVuYXRpb24sIGEgc3Ry ZWFtIHN0YXJ0aW5nIG1pZC1jb250ZW50KSwgdGhlIGNvcHkgbG9zZXMgaW5mb3JtYXRpb24gdGhh dCBpc24ndCByZWNvcmRlZCBhbnl3aGVyZSBlbHNlLiBPbiBhIGZpbGUgd2l0aCB0cmltX3N0YXJ0 IDYwMCBhbmQgcHJlX3NraXAgMTIwLCBmZm1wZWcgZGVjb2RlcyB0aGUgb3JpZ2luYWwgdG8gNDc5 LDUyMCBmcmFtZXMgYW5kIHRoZSBjb3B5IHRvIDQ4MCwwMDAg4oCUIDQ4MCBleHRyYSBsZWFkaW5n IHNhbXBsZXMsIHJlbWFpbmRlciBieXRlLWlkZW50aWNhbC4NCg0KV291bGQgc29tZXRoaW5nIGxp a2UgdGhpcyBiZSB0aGUgcmlnaHQgc2hhcGUsIG9yIGFtIEkgbWlzcmVhZGluZyB0aGUgaW50ZW50 Pw0KDQpjDQppZiAoY29kZWNfY29uZmlnLT5jb2RlY19pZCA9PSBBVl9DT0RFQ19JRF9PUFVTKSB7 DQogICAgaWYgKCFzaWRlX2RhdGEgJiYgcGt0LT5kdHMgPCAwKQ0KICAgICAgICBza2lwX3NhbXBs ZXMgPSBhdl9yZXNjYWxlKC1wa3QtPmR0cywgNDgwMDAsIHBrdC0+dGltZV9iYXNlLmRlbik7DQog ICAgZGlzY2FyZF9wYWRkaW5nID0gYXZfcmVzY2FsZShkaXNjYXJkX3BhZGRpbmcsIDQ4MDAwLCBw a3QtPnRpbWVfYmFzZS5kZW4pOw0KfQ0KU2FtZSBiZWhhdmlvdXIgb24gbjguMS4yIGFuZCBtYXN0 ZXIgYzYzMDliNWM7IGhhcHB5IHRvIHNlbmQgYSBzYW1wbGUgZmlsZSBvciB0ZXN0IGEgcGF0Y2gu DQoNClRoYW5rcyBmb3IgYW55IGluZm8uDQoNCi1KYW1lcwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpmZm1wZWctZGV2ZWwgbWFpbGluZyBsaXN0IC0tIGZm bXBlZy1kZXZlbEBmZm1wZWcub3JnClRvIHVuc3Vic2NyaWJlIHNlbmQgYW4gZW1haWwgdG8gZmZt cGVnLWRldmVsLWxlYXZlQGZmbXBlZy5vcmcK