Re: commit c2802e520a now requires macOS 12

On 8/4/26 10:21 AM, Helmut K. C. Tessarek via ffmpeg-devel wrote:
> Once again I am sorry to bother the devs, but this mailing list is 
> supposed to be for dev discussions as well.
> 
> The commit actually uses #ifdef blocks, but I still get an error when 
> compiling with MACOSX_DEPLOYMENT_TARGET=10.13
> 
> I suspect that there was an oversight or does ffmpeg really require a 
> minimum version of macOS 12? I also understand that both 10.13 and 12.x 
> are long out of support. I am not against raising the minimum level, but 
> I just want to make sure that it is absolutely necessary. In the past 
> something similar happened and it turned out that the code was missing 
> another ifdef block.

The #ifdef in question:

#   if defined(__MAC_OS_X_VERSION_MAX_ALLOWED) && 
__MAC_OS_X_VERSION_MAX_ALLOWED >= 120000
#       define AVF_IO_MAIN_PORT_DEFAULT kIOMainPortDefault
#   else
#       define AVF_IO_MAIN_PORT_DEFAULT kIOMasterPortDefault
#   endif

I'm not sure setting _MAX_ALLOWED to anything here is the correct check
(as that reads to me that it unconditionally enables kIOMainPortDefault
as the alias and never drops to the #else condition), versus using
_MIN_ALLOWED or a different API check entirely.

Or it is supposed to work correctly due to weird naming conventions in
the SDK, but depends on -mmacosx-version-min= being set in the
CFLAGS/LDFLAGS instead of/in addition to using the 
MACOSX_DEPLOYMENT_TARGET environment variable.
_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]