[PR] fate-recv.sh: match only compiler diagnostics when counting warnings (PR #3)

PR #3 opened by Kacper Michajłow (kasper93)
URL: https://code.ffmpeg.org/FFmpeg/fateserver/pulls/3
Patch URL: https://code.ffmpeg.org/FFmpeg/fateserver/pulls/3.patch

Plain \<warning\> also matched clang's "1 warning generated." summary and
its "note: ... to silence this warning" lines. Both warnings count and
filtering was noisy because of that. Require a colon after, as every real
diagnostic has one.

Note that this is not a new issues, but after recent addition of
/warnings filtering it was made more annoying.


From 7142fa92ffa40d195f438a8617c1a3a6a74150d8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kacper=20Michaj=C5=82ow?= <[email protected]>
Date: Mon, 10 Aug 2026 21:19:47 +0200
Subject: [PATCH] fate-recv.sh: match only compiler diagnostics when counting
 warnings
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Plain \<warning\> also matched clang's "1 warning generated." summary and
its "note: ... to silence this warning" lines. Both warnings count and
filtering was noisy because of that. Require a colon after, as every real
diagnostic has one.

Note that this is not a new issues, but after recent addition of
/warnings filtering it was made more annoying.

Signed-off-by: Kacper Michajłow <[email protected]>
---
 fate-recv.sh | 6 +++++-
 log.cgi      | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/fate-recv.sh b/fate-recv.sh
index 668f490..958dad6 100755
--- a/fate-recv.sh
+++ b/fate-recv.sh
@@ -105,7 +105,11 @@ fi
 
 unset IFS
 
-nwarn=$(grep -Ei '\<warning\>' compile.log test.log 2>/dev/null | wc -l)
+# Match compiler diagnostics:
+# gcc/clang/ld "warning:"
+# msvc "warning Cnnnn:" and "warning Dnnnn :"
+# armasm "warning A4228:"
+nwarn=$(grep -Ei '\<warning\>[^:]*:' compile.log test.log 2>/dev/null | wc -l)
 
 echo "stats:$ntest:$npass:$nwarn" >>summary
 
diff --git a/log.cgi b/log.cgi
index 237ee40..30ddd6f 100755
--- a/log.cgi
+++ b/log.cgi
@@ -41,7 +41,7 @@ sub warnings_in {
         while (<$fh>) {
             chomp;
             s/\r$//;
-            $count{$_}++ if /\bwarning\b/i;
+            $count{$_}++ if /\bwarning\b[^:]*:/i;
         }
         close $fh;
     }
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]