Re: Fairy-PRs
Michael Niedermayer via ffmpeg-devel <[email protected]>
| Newsgroups | gmane.comp.video.ffmpeg.devel |
|---|---|
| Message-ID | <apI_QsHLS6sNPdFm@neo> |
On Fri, Aug 28, 2026 at 10:53:12PM +0200, Michael Niedermayer via ffmpeg-devel wrote: > Hi James > > On Fri, Aug 28, 2026 at 04:03:14PM +0200, Michael Niedermayer via ffmpeg-devel wrote: > > Hi James > > > > On Thu, Aug 27, 2026 at 04:33:15PM -0300, James Almer via ffmpeg-devel wrote: > > > On 8/27/2026 2:29 PM, Michael Niedermayer via ffmpeg-devel wrote: > > > > Hi everyone > > > > > > > > Fairy now has her own git repository and she can open pull requests > > > > > > No, this is not ok. Commits need to have human and traceable authorship. AI > > > can't be held responsible for mistakes. > > > > I agree > > but really thers at least 2 things here > > > > 1. development resposibility, following up on comments on a PR ans such > > > > fairy cannot do that ATM but it can be added > > > > > > 2. morally being responsible for a patch > > > > Of course Fairy cannot be that. But with humans its also going to be a > > gentelmans agreement, if one breaks it you are out of luck still. > > > > > > > > > > > > > > > Thats her first one: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/24293 > > > > (which she opened as part of investigating issue21153) > > > > > > Then please open a new PR with a commit under your authorship if you think > > > the change is correct, quoting Fairy as co-author. > > > > I shall look into doing that. > > Heres the new variant of this: > https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/24308/commits > > commit authored by my (so there is human resposibility), PR opened by fairy > and i safed alot of time > > And fairy all on her own fixed a bug, added a regression test and opened a PR > I quickly reviewed it before approving Heres another one: https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/22696 This is about backporting a security fix. 1. The author points to the 2 patches 2. Marvin asks for 2 PR to be opened 3. 4 month pass while fairy doesnt support opening pull requests 4. Fairy opens 2 pull requests, she correctly assigned authorship and correctly credited the researcher thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing something just because microsoft did it is even more stupid. If everything ms did were stupid they would be bankrupt already. _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
signature.asc
(application/pgp-signature, 195 B)
-----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCapI/PgAKCRBhHseHBAsP q/zZAKCIndwdLI7ekUdP7rpk8MzuhcmBJgCfcvCplqe/M7FKHZzgr3FYXE7aa+Q= =P3hL -----END PGP SIGNATURE-----