Re: [Freevo-cvslog] Kaa r4286 - trunk/WIP/webmetadata/src

On Fri, 2010-01-01 at 20:15 +0100, Dirk Meyer wrote:
> +WORKER_THREAD = 'WEBMETADATA'

I don't think a constant is needed here.  If you use the literal string
elsewhere and happen to typo it, you will get a warning now, and an
exception later (once we remove implicit thread pool creation).

Also, the name of the thread pool should follow the documentation
recommendations:

    Thread pool names are arbitrary strings, but the recommended convention
    is to format the pool name as ``appname::poolname``, where ``appname``
    uniquely identifies the application, and ``poolname`` describes the purpose
    of the thread pool.  An example might be ``beacon::thumbnailer``.

So it should be called, say, 'webmetadata::worker'

BTW, Happy New Year. :)


------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev