Re: Patch for kaa.epg
Jason Tackaberry <[email protected]>
| Newsgroups | gmane.comp.video.freevo.devel |
|---|---|
| Message-ID | <1272552830.21155.1934.camel@arrakis> |
On Thu, 2010-04-29 at 10:23 +0100, Adam Charrett wrote: > Yep tested using the test scripts in the tests directory :-) > 2nd patch attached. Thanks. Applied with a minor (untested) tweak. Let me know if I broke it. :) Now that I look at it again a bit more closely, it'd be nice to make the generic mapping stuff a bit smarter and support elements as both lists (program-name and now category), rather than handle those things separately and explicitly. It wasn't a big deal with just one exception (program-name) but now with two it's starting to ask to be factored out. I wouldn't worry about it so much now unless you're motivated to clean it up, but I'd definitely want to see it fixed up before a third such element is added. Thanks for the patch, Adam. Jason. ------------------------------------------------------------------------------