web/hosts/issues/html bug.item,1.12,1.13 issues.js,1.1,1.2 milestone.item,1.10,1.11

Tobias Hunger <[email protected]> Mon, 25 Aug 2003 11:32:16 -0500
Newsgroups gmane.comp.video.fresco.cvs
Message-ID <[email protected]>
Update of /cvs/fresco/web/hosts/issues/html
In directory purcel:/tmp/cvs-serv15619/html

Modified Files:
	bug.item issues.js milestone.item 
Log Message:
Played with the permissions once more:

* Developers should now be able to comment on milestones, add themselves to
  nosy lists there, etc.
* You need to be a developer to change certain settings on a bug. Going round
  the webinterface shouldn't work anymore.
* Only developers are allowed to modify tasks.
* Do some sanity checks on all bugs/tasks/milestones before commiting them
  to the DB (and reject invalid changes)


Index: bug.item
===================================================================
RCS file: /cvs/fresco/web/hosts/issues/html/bug.item,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -d -r1.12 -r1.13
--- bug.item	21 Aug 2003 19:29:56 -0000	1.12
+++ bug.item	25 Aug 2003 16:32:13 -0000	1.13
@@ -14,7 +14,7 @@
       enctype="multipart/form-data">
 
   <input type="hidden" name=":template" value="item">
-  <input type="hidden" name=":required" value="title,priority">
+  <input type="hidden" name=":required" value="title,bug_type">
 
   <table class="form">
 
@@ -65,7 +65,7 @@
         assignedto
       </td>
       
-      <th class="required">
+      <th>
         <a href="javascript:help_window('priority?:template=help&properties=name,description', 500, 400)">priority</a>
       </th>
       <td colspan="2"
@@ -82,13 +82,17 @@
 
     <!-- bug_type, severity -->
     <tr>
-      <th><a href="javascript:help_window('bug_type?:template=help&properties=name,description', 500, 400)">type</a></th>
+      <th class="required">
+        <a href="javascript:help_window('bug_type?:template=help&properties=name,description', 500, 400)">type</a>
+      </th>
       <td colspan="2"
-          tal:condition="python:request.user.hasPermission('Process')"
+          tal:condition="python:request.user.hasPermission('Process') or
+                         not context.id"
           tal:content="structure python:context.bug_type.menu(size=60)">type
       </td>
       <td colspan="2"
-          tal:condition="python:not request.user.hasPermission('Process')"
+          tal:condition="python:not ( request.user.hasPermission('Process') or
+                                      not context.id )"
           tal:content="structure context/bug_type/plain">type
       </td>
 

Index: issues.js
===================================================================
RCS file: /cvs/fresco/web/hosts/issues/html/issues.js,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- issues.js	12 Oct 2002 20:56:06 -0000	1.1
+++ issues.js	25 Aug 2003 16:32:13 -0000	1.2
@@ -12,9 +12,9 @@
 
 function help_window(helpurl, width, height)
 {
-  HelpWin = window.open('http://issues.fresco.org/' + helpurl, 'RoundupHelpWindow', 'scrollbars=yes,resizable=yes,toolbar=no,height='+height+',width='+width);
+  HelpWin = window.open(TRACKER_WEB + helpurl, 'RoundupHelpWindow', 'scrollbars=yes,resizable=yes,toolbar=no,height='+height+',width='+width);
 }
 function schema_window(helpurl, width, height)
 {
-  HelpWin = window.open('http://issues.fresco.org/' + helpurl, 'RoundupSchemaWindow', 'scrollbars=yes,resizable=yes,toolbar=no,height='+height+',width='+width);
+  HelpWin = window.open(TRACKER_WEB + helpurl, 'RoundupSchemaWindow', 'scrollbars=yes,resizable=yes,toolbar=no,height='+height+',width='+width);
 }

Index: milestone.item
===================================================================
RCS file: /cvs/fresco/web/hosts/issues/html/milestone.item,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -d -r1.10 -r1.11
--- milestone.item	21 Aug 2003 16:33:06 -0000	1.10
+++ milestone.item	25 Aug 2003 16:32:13 -0000	1.11
@@ -15,7 +15,6 @@
       enctype="multipart/form-data">
 
   <input type="hidden" name=":template" value="item">
-  <input type="hidden" name=":required" value="title">
 
   <table class="form">
 
@@ -23,12 +22,12 @@
     <tr>
       <th class="required" nowrap>Title</th>
       <td colspan="5"
-          tal:condition="context/is_edit_ok"
+          tal:condition="python: request.user.hasPermission('Process')"
           tal:content="structure python:context.title.field(size=60)">
         title
       </td>
       <td colspan="5"
-          tal:condition="not:context/is_edit_ok"
+          tal:condition="python: not request.user.hasPermission('Process')"
           tal:content="structure context/title/plain">
         title
       </td>
@@ -50,12 +49,12 @@
 escription', 500, 400)">status</a>
       </th>
       <td colspan="5"
-          tal:condition="context/is_edit_ok"
+          tal:condition="python: request.user.hasPermission('Process')"
           tal:content="structure context/status/menu">
         status
       </td>
       <td colspan="5"
-          tal:condition="not:context/is_edit_ok"
+          tal:condition="python: not request.user.hasPermission('Process')"
           tal:content="structure context/status/plain">
         status
       </td>
@@ -65,7 +64,7 @@
     <tr>
       <th>Bugs</th>
       <td colspan="2"
-          tal:condition="context/is_edit_ok">
+          tal:condition="python: request.user.hasPermission('Process')">
         <table>
           <tr>
               Add: <input name=":add:bugs"  size="20">
@@ -85,7 +84,7 @@
         </table>
       </td>
       <td colspan="2"
-        tal:condition="not:context/is_edit_ok">
+        tal:condition="python: not request.user.hasPermission('Process')">
         <span tal:condition="context/bugs"
               tal:repeat="bug context/bugs">
           <br/>View:
@@ -99,7 +98,7 @@
      
       <th>Tasks</th>
       <td colspan="2"
-          tal:condition="context/is_edit_ok"> 
+          tal:condition="python: request.user.hasPermission('Process')"> 
         <table>
           <tr>
               Add: <input name=":add:tasks"  size="20">
@@ -120,7 +119,7 @@
         </table>
       </td>
       <td colspan="2"
-          tal:condition="not:context/is_edit_ok">
+          tal:condition="python: not request.user.hasPermission('Process')">
         <span tal:condition="context/tasks"
               tal:repeat="task context/tasks">
           <br/>View: