Re: [Fresco-devel] Re: [Fresco-changes] Fresco/Prague/include/Prague/IPC Dispatcher.hh,1.11,1.12

Stefan Seefeld <[email protected]> wrote:
> I appreciate your work on this code !
> However, some of these changes are non-trivial, and may introduce some
> undesired sideeffects.
>
> As we discussed already in the past, I would much prefer such changes
> to be discussed / reviewed on issues.fresco.org before they get checked
> in.

I do understand that 'visible' changes need to be discussed (I did open two new
bugs/rfe's yesterday for three such changes I'd like to do), I do understand that
big changes like styleguide indention changes need to be communicated to make
sure that this won't make the live harder for someone else (and I did get your
OK before commiting that as Prague is your code), I do see the need to
discuss any changes on code actively worked on by more than one person. I do
see the need to discuss changes to the architecture of a subsystem or of the
interaction between classes (private helper classes do not count though).

However I do not see the need to discuss bug fixes on code that had not been
touched in month (or even years).

As I see it my commit fixed the situation were one agent is registered for
several fds and fixes the unregistering process. It did only touch private
members/vars, so it should be reasonable to assume not too many sideefffects.
It further should be possible to test those changes with the unit test framework
we have in the tree for a while now and I will start to write some tests for
Prague next week (just to make sure I did not break anything). We further do
use a versioning system that allows us to go back in time and remove undesired
and or broken changes again.

For those reasons I did not and do not see a reason to discuss the changes I
did commit beforehand.

How do others see this? What needs to be discussed? What is a non-trivial
change?

PS: Do you see any problem with the code I commited? I'd be happy to fix it if
    it is broken.

-- 
Gruss,
Tobias

------------------------------------------------------------
Tobias Hunger           The box said: 'Windows 95 or better'
[email protected]                      So I installed Linux.
------------------------------------------------------------

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/pPK/v0FZW3NyoqURAq/wAKCwBUpJ5nRgBS9MTRY77ga3qNxLcwCfVMcC
Ktu8M+PhKtIZ7m5Y9cYnrKQ=
=SjRA
-----END PGP SIGNATURE-----