Re: list based patch reviews

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

nice!

Martin Bayer wrote:
| Hi,
|
| At the moment changes in the codebase are just seen by the original
| patch author. It would be nice to introduce a public review process to
| improve the patch quality.
|
| A full pre commit patch review for all changes is in my opinion a bit to
| disruptive for our current development process. It introduces an
| additional latency and slows things down. It shouldn't be mandatory for
| a patch to be reviewed before entering the codebase.
|
| This leads to lightweight post commit reviews.
|
| I installed a post commit hook in the gephex main repository that
| automatically sends every committed patch for public review to this
| mailing list.
|
| There could be two effects that improve the code quality:
|
| 1. As the patch author knows that the diff of every commit is posted to
| the list he tries to commit better patches.
|
| 2. If a problematic patch enters the code base. It is detected more
| quickly. After a discussion on the list the patch or the problematic
| part could the reverted.
|
| What do you think about it?
|
| Martin
| _______________________________________________
| gephex-devel mailing list
| [email protected]
| http://lists.gephex.org/mailman/listinfo/gephex-devel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFBYEGNYrdEvBZIgToRAqTtAJwLiJCD4lnk+OAe8UziX0gwFh2UjgCgm8WR
N7dbpkeuX3XC3gQeTyCqrF4=
=kjqV
-----END PGP SIGNATURE-----