[Gimp-developer] Please review my patch

My last comment in https://gitlab.gnome.org/GNOME/gimp/-/issues/2933 is:
"Could someone please review this patch? It works. . . . This is a year 
old bug that could be fixed if someone would just commit the code. The 
corresponding bug in GEGL hue-chroma has been fixed - maybe we could get 
this fixed also in GIMP? Maybe even in GIMP-2.10?"
#endquote

Seven months later still nobody has reviewed the patch.

A similar bug report, almost certainly the exact same bug - can't see 
how it could be anything else - was filed recently:
https://gitlab.gnome.org/GNOME/gimp/-/issues/6308

to which bug report a request for "Additional Diagnostics" was attached.

The requested "Diagnostics" were available 8 months ago in bug #2933. 
It's a matter of precision. The "EPSILON" value used in the layer blend 
code is too small to eliminate unavoidable rounding errors in the LCh 
Chroma code.

I attached an updated patch to the new bug report. The update doesn't 
change the actual code that fixes the problem - it just allows the patch 
to be applied to the affected layer blend file given other recent 
changes to the file.

I can guess the response from other devs as to why nobody has taken the 
time to review my patch: Other priorities, too few developers, too much 
to do, nobody else has color management or color science as a top priority.

I do understand the problem of too few devs, but if one of the GIMP devs 
could take it upon themselves to finally get around to checking my 
patch, then three bug reports could be closed: the two mentioned above 
and also https://gitlab.gnome.org/GNOME/gimp/-/issues/2934 - leastways 
I'm pretty sure the latter bug is also fixed - none of these three bugs 
affect the already-patched version of GIMP that I use for editing.

I had totally forgotten about bugs #2933 and #2934 (which I filed a year 
ago) until bug #6308 was filed. There's nothing else I can do about 
these bugs. I don't have - and don't want - commit rights to GIMP code. 
Some other GIMP dev needs to actually check the patch and decide it 
works and then apply it.

Regards,
Elle
-- 
https://ninedegreesbelow.com
Color management and free/libre photography
_______________________________________________
gimp-developer-list mailing list
List address:    [email protected]
List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list
List archives:   https://mail.gnome.org/archives/gimp-developer-list