Re: Patches for security issues and other problems.

On Tue, Jan 03, 2006 at 04:27:16PM -0600, Bob Friesenhahn wrote:
> On Tue, 3 Jan 2006, Daniel Kobras wrote:
> >* CAN-2005-0397 (Format string vulnerability in magick/image.c)
> > Was originally reported against ImageMagick 6.x because the affected
> > function had been renamed, but also needs to be fixed in 5.x and
> > GraphicsMagick. Patch against 1.1.7 attached.
> 
> The chunk of code being patched is indeed known to be broken.  The 
> proposed patch simply breaks it even more.  It really was intended 
> that image_info->filename contain a printf style specification since 
> the code is testing to see if there is a %d specification in the 
> filename which can be substituted.

Sorry, you're right. I had just looked at the security patch that was
applied to the imagemagick packages without checking for correctness.
Well, at least it plugged the security hole. Looking at current IM,
they've implemented a more complex fix, but I'd say this version should
now choke on things like foo%d%n.jpg. Anyway, this should be easily
fixable.

Regards,

Daniel.



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click