Re: GraphicsMagick file globbing fixes
Bob Friesenhahn <[email protected]>
| Newsgroups | gmane.comp.video.graphicsmagick.core |
|---|---|
| Message-ID | <[email protected]> |
I notice that there are existing memory leaks related to the argument vectors which are now more obvious due to ExpandFilenames always returning a new argument vector allocation (it used to be conditional based on whether tilde expansion or globbing had been performed). I will attend to these today. Bob On Sat, 19 Apr 2003, Bob Friesenhahn wrote: > I have just committed many fixes to the ExpandFilenames function. It > is perhaps not well known that a file specification like > "JPEG:~/myfiles/*.jpg" (quotes required to avoid expansion by the > shell) is supported via internal file globbing in GraphicsMagick. > This is handy in order to avoid shell argument length limitations. > > The committed fixes are: > > * magick/utility.c (ExpandFilenames): Handle tilde expansion > properly. Handle relative glob specifications. Skip over "*" > argument to +profile properly. Don't expand VID: specifications > since the VID: coder will execute ExpandFilenames() later. Apply > format specifier prefix to globbed file names. Fix double frees > and rationalize memory management by always copying to a new > vector. > > Note that directory path globbing is not yet supported. Only filename > level globbing is currently supported. > > If you are using CVS to access GraphicsMagick, I would appreciate it > if you would test the built-in globbing to make sure that I have not > introduced any negative side-effects. > > Note that current development for 1.0 is on the GraphicsMagick-1_0 > branch, so you must either do a "cvs update -r GraphicsMagick-1_0" to > transition to that branch, or add "-r GraphicsMagick-1_0" to the > options when you check out the sources. If you don't do that, you > will get sources from the trunk, which is currently not being updated. > > Bob > ====================================== > Bob Friesenhahn > [email protected] > http://www.simplesystems.org/users/bfriesen > > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Welcome to geek heaven. > http://thinkgeek.com/sf > _______________________________________________ > Graphicsmagick-core mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/graphicsmagick-core > ====================================== Bob Friesenhahn [email protected] http://www.simplesystems.org/users/bfriesen ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf