Fixed bug in DrawPopPattern()

Peter Boos <[email protected]> Fri, 7 May 2004 15:52:36 +0800
Newsgroups gmane.comp.video.graphicsmagick.core
Message-ID <[email protected]>
I found a bug in DrawPopPattern(). I'm not sure whether this corrected code 
produces side-effects.

Peter

Index: ChangeLog
===================================================================
RCS file: /GraphicsMagick/GraphicsMagick/ChangeLog,v
retrieving revision 1.887
diff -u -r1.887 ChangeLog
--- ChangeLog	20 Apr 2004 00:43:10 -0000	1.887
+++ ChangeLog	7 May 2004 11:49:45 -0000
@@ -1,3 +1,10 @@
+2004-05-07  Peter Boos  <[email protected]>
+
+	* In magich/draw.c line 4041, SetImageAttribute() concatenates
+	the path and the geometry, but in magich/render.c line 3064 the codes
+	assume a "<pattern_id>-geometry" string. This finally produces an exception.
+	It is now fixed.
+
 2004-04-19  Patrick Welche  <[email protected]>
 
 	* www/header.html: HTML syntax fixes.
Index: magick/draw.c
===================================================================
RCS file: /GraphicsMagick/GraphicsMagick/magick/draw.c,v
retrieving revision 1.614
diff -u -r1.614 draw.c
--- magick/draw.c	15 Mar 2004 00:33:46 -0000	1.614
+++ magick/draw.c	7 May 2004 11:50:28 -0000
@@ -4033,8 +4033,9 @@
     
ThrowDrawException(DrawWarning,NotCurrentlyPushingPatternDefinition,NULL);
 
   FormatString(key,"[%.1024s]",context->pattern_id);
-
   (void) 
SetImageAttribute(context->image,key,context->mvg+context->pattern_offset);
+
+  FormatString(key,"[%.1024s]-geometry",context->pattern_id);
   FormatString(geometry,"%lux%lu%+ld%+ld",
                context->pattern_bounds.width,context->pattern_bounds.height,
                context->pattern_bounds.x,context->pattern_bounds.y);



-------------------------------------------------------
This SF.Net email is sponsored by Sleepycat Software
Learn developer strategies Cisco, Motorola, Ericsson & Lucent use to deliver
higher performing products faster, at low TCO.
http://www.sleepycat.com/telcomwpreg.php?From=osdnemail3