Re: documentation patch

On Sat, 29 Nov 2003, Wolfgang Spraul wrote:

> Bob -
>
> attached a (very) minor patch to the documentation. I'm slowly getting up to
> speed with the sources...
>
> I understand the website says to post patches to the sf.net patch system, but
> I personally prefer the usage of mailing lists for patches (I hope sf.net
> won't drop the attachment). Please let me know whether you really want
> patches to go to the sf.net patch submission system.
>
> Hopefully the patch is correct...

I am happy to receive patches via email, however, this patch is not
correct! :-)

The reason why it is not correct is because if the image has a
colormap (GIF, colormapped PNG, etc.), then it does take 5 quantums
per pixel (at least for Q:8 and Q:16 builds) since the colormap index
takes a quantum.  We don't allow colormap sizes larger than 64K
entries, so the colormap index is still two bytes for the Q:32 build.

If you would like to submit an improved patch that describes a base
requirement of 4 quantums per pixel, with an additional quantum when a
colormap is needed, then that would be great.  There is also a small
allocation for the colormap array itself.

GraphicsMagick uses an unusual bi-modal scheme which allows both a
direct and indirect representation of the image to exist
simultaneously.  A flag is used to remember which representation is
the current working representation.

Bob
======================================
Bob Friesenhahn
[email protected]
http://www.simplesystems.org/users/bfriesen



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/