GraphicsMagick: QuantumPowCB() - Fix Coverity issue 381865 "Cont...

GraphicsMagick Commits <[email protected]>
Newsgroups gmane.comp.video.graphicsmagick.cvs
Message-ID <mailman.14666.1667941310.1459.graphicsmagick-commit@lists.sourceforge.net>
changeset 867fb2e8d253 in /hg/GraphicsMagick
details: http://hg.GraphicsMagick.org/hg/GraphicsMagick?cmd=changeset;node=867fb2e8d253
summary: QuantumPowCB() - Fix Coverity issue 381865 "Control flow issues (DEADCODE)"

diffstat:

 ChangeLog          |  3 +++
 magick/operator.c  |  6 ++++--
 www/Changelog.html |  5 ++++-
 3 files changed, 11 insertions(+), 3 deletions(-)

diffs (57 lines):

diff -r 4fe7cfbb3e00 -r 867fb2e8d253 ChangeLog
--- a/ChangeLog	Tue Nov 08 14:56:22 2022 -0600
+++ b/ChangeLog	Tue Nov 08 15:01:41 2022 -0600
@@ -2,12 +2,15 @@
 
 	* magick/operator.c (QuantumDepthCB): Fix Coverity issue 381867
 	"Control flow issues (DEADCODE)".
+	(QuantumPowCB): Fix Coverity issue 381865 "Control flow issues
+	(DEADCODE)".
 
 	* magick/import.c (ImportViewPixelArea): Fix Coverity issue 381868
 	"Control flow issues (DEADCODE)".
 
 	* magick/blob.c (DetachBlob): Do not dereference blob_info->data
 	if it is null.  Addresses Coverity issue 381869 "Null pointer
+	dereferences (FORWARD_NULL)"and issue 381866 "Null pointer
 	dereferences (FORWARD_NULL)".
 
 	* coders/jpeg.c (FreeMagickClientData): Fix Coverity issue 381870
diff -r 4fe7cfbb3e00 -r 867fb2e8d253 magick/operator.c
--- a/magick/operator.c	Tue Nov 08 14:56:22 2022 -0600
+++ b/magick/operator.c	Tue Nov 08 15:01:41 2022 -0600
@@ -1586,11 +1586,13 @@
                                            immutable_context->double_value));
         }
     }
+
+  if (MagickFail == status)
+    return status;
 #else
   ARG_NOT_USED(*mutable_context);
+  ARG_NOT_USED(status);
 #endif
-  if (MagickFail == status)
-    return status;
 
   switch (immutable_context->channel)
     {
diff -r 4fe7cfbb3e00 -r 867fb2e8d253 www/Changelog.html
--- a/www/Changelog.html	Tue Nov 08 14:56:22 2022 -0600
+++ b/www/Changelog.html	Tue Nov 08 15:01:41 2022 -0600
@@ -41,11 +41,14 @@
 <blockquote>
 <ul class="simple">
 <li><p>magick/operator.c (QuantumDepthCB): Fix Coverity issue 381867
-&quot;Control flow issues (DEADCODE)&quot;.</p></li>
+&quot;Control flow issues (DEADCODE)&quot;.
+(QuantumPowCB): Fix Coverity issue 381865 &quot;Control flow issues
+(DEADCODE)&quot;.</p></li>
 <li><p>magick/import.c (ImportViewPixelArea): Fix Coverity issue 381868
 &quot;Control flow issues (DEADCODE)&quot;.</p></li>
 <li><p>magick/blob.c (DetachBlob): Do not dereference blob_info-&gt;data
 if it is null.  Addresses Coverity issue 381869 &quot;Null pointer
+dereferences (FORWARD_NULL)&quot;and issue 381866 &quot;Null pointer
 dereferences (FORWARD_NULL)&quot;.</p></li>
 <li><p>coders/jpeg.c (FreeMagickClientData): Fix Coverity issue 381870
 &quot;Null pointer dereferences&quot;.</p></li>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.